Make test join_with_hash_collision deterministic #229
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 76.46% 76.46%
=======================================
Files 135 135
Lines 23250 23250
=======================================
Hits 17777 17777
Misses 5473 5473
Continue to review full report at Codecov.
|
jorgecarleitao
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
LGTM. Thanks @Dandandan 👍 This will make python-datafusion green :)
|
First merge!!! 🎉🎉🎉🎉 |
Woohoo |
mustafasrepo
added a commit
that referenced
this pull request
Dec 25, 2023
Co-authored-by: Mustafa Akur <[email protected]>
mustafasrepo
added a commit
that referenced
this pull request
Dec 25, 2023
Co-authored-by: Mustafa Akur <[email protected]>
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
* chore: Handle deprecation of timestamp_micros() * chore: Handle deprecation of seconds() --------- Co-authored-by: Steve Vaughan Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #227
Rationale for this change
Fix non-deterministic test
What changes are included in this PR?
Initialize the random state with a constant seed, so no hashes will end up with the same entry by chance.
Are there any user-facing changes?
No
FYI
@jorgecarleitao