-
Notifications
You must be signed in to change notification settings - Fork 4.8k
[Improvement-17025][UI] optimize queryLog to avoid infinite recursive invoke #17029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
I am not sure if this PR can solve this problem, the main reason is the front-end doesn't know whether it should stop fetch log, since it doesn't know if the log had come to the end, the response doesn't tell the front-end where there exist more log. @Data
@AllArgsConstructor
public class ResponseTaskLog {
private int lineNum;
private String message;
} |
Purpose of the pull request
This PR optimizes the getLog method to avoid infinite recursive invoke in front end
close #17025
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.