HDFS-9913 DistCp to add -useTrash to move deleted files to Trash #1111

asagjj · 2019-07-17T13:07:23Z

No description provided.

hadoop-yetus · 2019-07-19T11:00:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	66	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1107	trunk passed
+1	compile	26	trunk passed
+1	checkstyle	18	trunk passed
+1	mvnsite	31	trunk passed
+1	shadedclient	707	branch has no errors when building and testing our client artifacts.
+1	javadoc	25	trunk passed
0	spotbugs	42	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	40	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	25	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
-0	checkstyle	13	hadoop-tools/hadoop-distcp: The patch generated 2 new + 136 unchanged - 0 fixed = 138 total (was 136)
+1	mvnsite	25	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	713	patch has no errors when building and testing our client artifacts.
+1	javadoc	16	the patch passed
+1	findbugs	47	the patch passed
		_ Other Tests _
+1	unit	890	hadoop-distcp in the patch passed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		3882

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/1/artifact/out/Dockerfile
GITHUB PR	#1111
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 5a373f99d388 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `4e66cb9`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-distcp.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/1/testReport/
Max. process+thread count	412 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-07-26T12:21:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	12	#1111 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#1111
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/2/console
versions	git=2.7.4
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-02T00:08:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	12	#1111 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#1111
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/3/console
versions	git=2.7.4
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-08T02:14:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	13	#1111 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#1111
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/4/console
versions	git=2.7.4
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-08T10:22:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	10	#1111 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#1111
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-16T16:14:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	11	#1111 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#1111
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/6/console
versions	git=2.7.4
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-20T14:37:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	73	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1057	trunk passed
+1	compile	23	trunk passed
+1	checkstyle	18	trunk passed
+1	mvnsite	22	trunk passed
+1	shadedclient	669	branch has no errors when building and testing our client artifacts.
+1	javadoc	19	trunk passed
0	spotbugs	39	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	38	trunk passed
-0	patch	56	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	27	the patch passed
+1	compile	21	the patch passed
+1	javac	21	the patch passed
-0	checkstyle	14	hadoop-tools/hadoop-distcp: The patch generated 3 new + 136 unchanged - 0 fixed = 139 total (was 136)
+1	mvnsite	21	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	792	patch has no errors when building and testing our client artifacts.
+1	javadoc	16	the patch passed
+1	findbugs	41	the patch passed
		_ Other Tests _
-1	unit	368	hadoop-distcp in the patch failed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		3320

Reason	Tests
Failed junit tests	hadoop.tools.mapred.TestCopyMapperCompositeCrc
	hadoop.tools.util.TestDistCpUtils
	hadoop.tools.TestDistCpWithRawXAttrs
	hadoop.tools.mapred.TestUniformSizeInputFormat
	hadoop.tools.TestFileBasedCopyListing
	hadoop.tools.TestDistCpSyncReverseFromSource
	hadoop.tools.TestGlobbedCopyListing
	hadoop.tools.TestDistCpSync
	hadoop.tools.mapred.TestCopyCommitter
	hadoop.tools.TestCopyListing
	hadoop.tools.util.TestDistCpUtilsWithCombineMode
	hadoop.tools.TestDistCpWithXAttrs
	hadoop.tools.mapred.TestCopyMapper
	hadoop.tools.TestDistCpSyncReverseFromTarget
	hadoop.tools.TestDistCpWithAcls
	hadoop.tools.mapred.lib.TestDynamicInputFormat
	hadoop.tools.TestDistCpSystem

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/7/artifact/out/Dockerfile
GITHUB PR	#1111
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 04a2375e6ef6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `094d736`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/7/artifact/out/diff-checkstyle-hadoop-tools_hadoop-distcp.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/7/artifact/out/patch-unit-hadoop-tools_hadoop-distcp.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/7/testReport/
Max. process+thread count	418 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-22T13:50:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	45	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1061	trunk passed
+1	compile	20	trunk passed
+1	checkstyle	17	trunk passed
+1	mvnsite	24	trunk passed
+1	shadedclient	643	branch has no errors when building and testing our client artifacts.
+1	javadoc	17	trunk passed
0	spotbugs	34	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	33	trunk passed
-0	patch	52	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	24	the patch passed
+1	compile	16	the patch passed
+1	javac	16	the patch passed
-0	checkstyle	13	hadoop-tools/hadoop-distcp: The patch generated 3 new + 136 unchanged - 0 fixed = 139 total (was 136)
+1	mvnsite	20	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	705	patch has no errors when building and testing our client artifacts.
+1	javadoc	16	the patch passed
+1	findbugs	39	the patch passed
		_ Other Tests _
+1	unit	782	hadoop-distcp in the patch passed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		3584

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/8/artifact/out/Dockerfile
GITHUB PR	#1111
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 3faeeaa5329c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 69ddb36
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/8/artifact/out/diff-checkstyle-hadoop-tools_hadoop-distcp.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/8/testReport/
Max. process+thread count	428 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-27T10:47:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	85	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1196	trunk passed
+1	compile	26	trunk passed
+1	checkstyle	24	trunk passed
+1	mvnsite	32	trunk passed
+1	shadedclient	817	branch has no errors when building and testing our client artifacts.
+1	javadoc	19	trunk passed
0	spotbugs	39	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	36	trunk passed
-0	patch	56	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	25	the patch passed
+1	compile	18	the patch passed
+1	javac	18	the patch passed
-0	checkstyle	15	hadoop-tools/hadoop-distcp: The patch generated 3 new + 136 unchanged - 0 fixed = 139 total (was 136)
+1	mvnsite	22	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	832	patch has no errors when building and testing our client artifacts.
+1	javadoc	17	the patch passed
+1	findbugs	43	the patch passed
		_ Other Tests _
+1	unit	848	hadoop-distcp in the patch passed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		4167

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/9/artifact/out/Dockerfile
GITHUB PR	#1111
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux c43c6f2291b8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3329257`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/9/artifact/out/diff-checkstyle-hadoop-tools_hadoop-distcp.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/9/testReport/
Max. process+thread count	348 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-09-03T02:31:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	74	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	1259	trunk passed
+1	compile	17	trunk passed
+1	checkstyle	19	trunk passed
+1	mvnsite	25	trunk passed
+1	shadedclient	838	branch has no errors when building and testing our client artifacts.
+1	javadoc	20	trunk passed
0	spotbugs	42	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	41	trunk passed
-0	patch	61	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1	mvninstall	24	the patch passed
+1	compile	18	the patch passed
+1	javac	18	the patch passed
-0	checkstyle	16	hadoop-tools/hadoop-distcp: The patch generated 3 new + 136 unchanged - 0 fixed = 139 total (was 136)
+1	mvnsite	22	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	842	patch has no errors when building and testing our client artifacts.
+1	javadoc	22	the patch passed
+1	findbugs	53	the patch passed
		_ Other Tests _
+1	unit	827	hadoop-distcp in the patch passed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		4244

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/10/artifact/out/Dockerfile
GITHUB PR	#1111
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 11cfb791f010 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `915cbc9`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/10/artifact/out/diff-checkstyle-hadoop-tools_hadoop-distcp.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/10/testReport/
Max. process+thread count	347 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1111/10/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

jojochuang

Overall looks good to me. Just two nits.

hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java

hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptions.java

asagjj · 2019-11-20T08:17:25Z

Thanks @jojochuang for review,I will update patch immediately.

steveloughran · 2020-05-07T10:28:32Z

forgot about this. What's the current status?

asagjj · 2020-05-11T03:21:21Z

I rebased trunk just now,please help to review.

steveloughran · 2020-05-18T16:04:26Z

...hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java

    Path trashRootDir = remoteFS.getTrashRoot(null);
-    ContractTestUtils.assertDeleted(remoteFS, trashRootDir, true);
-
+    remoteFS.delete(trashRootDir, true);


why did the assert fail here?

hadoop-yetus · 2020-07-31T18:30:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 29s	trunk passed
+1 💚	compile	0m 30s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 28s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 25s	trunk passed
+1 💚	mvnsite	0m 30s	trunk passed
+1 💚	shadedclient	14m 56s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 24s	hadoop-distcp in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 20s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	0m 40s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 38s	trunk passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 20s	hadoop-distcp in the patch failed.
-1 ❌	compile	0m 22s	hadoop-distcp in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	javac	0m 22s	hadoop-distcp in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	compile	0m 18s	hadoop-distcp in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
-1 ❌	javac	0m 18s	hadoop-distcp in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
-0 ⚠️	checkstyle	0m 17s	hadoop-tools/hadoop-distcp: The patch generated 3 new + 134 unchanged - 0 fixed = 137 total (was 134)
-1 ❌	mvnsite	0m 22s	hadoop-distcp in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 57s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 20s	hadoop-distcp in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 20s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	findbugs	0m 24s	hadoop-distcp in the patch failed.
		_ Other Tests _
-1 ❌	unit	0m 23s	hadoop-distcp in the patch failed.
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		58m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/Dockerfile
GITHUB PR	#1111
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux bee1b9f81f71 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `e756fe3`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/branch-javadoc-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
mvninstall	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-mvninstall-hadoop-tools_hadoop-distcp.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javac	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-compile-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-compile-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
javac	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-compile-hadoop-tools_hadoop-distcp-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/diff-checkstyle-hadoop-tools_hadoop-distcp.txt
mvnsite	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-mvnsite-hadoop-tools_hadoop-distcp.txt
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-javadoc-hadoop-tools_hadoop-distcp-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
findbugs	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-findbugs-hadoop-tools_hadoop-distcp.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/artifact/out/patch-unit-hadoop-tools_hadoop-distcp.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/testReport/
Max. process+thread count	477 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1111/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

asagjj mentioned this pull request Aug 19, 2019

HDFS-9913. DistCp to add -useTrash to move deleted files to Trash #974

Closed

steveloughran changed the title ~~Hdfs-9913 fix s3a unit test fails~~ HDFS-9913 DistCp to add -useTrash to move deleted files to Trash Aug 21, 2019

jojochuang requested changes Nov 19, 2019

View reviewed changes

hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java Outdated Show resolved Hide resolved

hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptions.java Outdated Show resolved Hide resolved

asagjj added 4 commits May 11, 2020 10:04

fix failed unit test and checkstyles

1e2b54b

Fix some typo and checksytes.

d90a7ea

Fix s3a unit test fails.

e284065

fix some nits

1cf6beb

asagjj force-pushed the HDFS-9913 branch from 85cf048 to 1cf6beb Compare May 11, 2020 02:30

steveloughran reviewed May 18, 2020

View reviewed changes

steveloughran mentioned this pull request Aug 10, 2020

HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy #2133

Merged

HDFS-9913 DistCp to add -useTrash to move deleted files to Trash #1111

Are you sure you want to change the base?

HDFS-9913 DistCp to add -useTrash to move deleted files to Trash #1111

Conversation

asagjj commented Jul 17, 2019

Uh oh!

hadoop-yetus commented Jul 19, 2019

Uh oh!

hadoop-yetus commented Jul 26, 2019

Uh oh!

hadoop-yetus commented Aug 2, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

hadoop-yetus commented Aug 8, 2019

Uh oh!

hadoop-yetus commented Aug 16, 2019

Uh oh!

hadoop-yetus commented Aug 20, 2019

Uh oh!

hadoop-yetus commented Aug 22, 2019

Uh oh!

hadoop-yetus commented Aug 27, 2019

Uh oh!

hadoop-yetus commented Sep 3, 2019

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

asagjj commented Nov 20, 2019

Uh oh!

steveloughran commented May 7, 2020

Uh oh!

asagjj commented May 11, 2020

Uh oh!

steveloughran May 18, 2020

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jul 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants