HDFS-16373. Fix MiniDFSCluster restart in case of multiple namenodes. #3756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajjasani
reviewed
Dec 7, 2021
Comment on lines
2793
to
2798
There was a problem hiding this comment.
How about re-throwing as IOE because ultimately main thread getting interrupted is going to be problematic? throw new IOException(e)
Even without this patch, catching InterruptedException was no-op but I believe re-throwing it as IOException might help us analyze any hidden bug underneath. Thoughts?
There was a problem hiding this comment.
Logically made sense, so I have changed it, In general I don't expect any test to fail due to this, but if any will revert to normal, considering minidfs is used by a lot of downstream projects as well
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
Outdated
Show resolved
Hide resolved
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
Outdated
Show resolved
Hide resolved
Comment on lines
+314
to
+315
There was a problem hiding this comment.
Shall we just do restarts rather than shutdown + restart?
There was a problem hiding this comment.
I don't think that will repro the issue, Single restart shall pass only since all other namenodes are up. May be just one shutdown and the other one restarting will repro...
But that won't look good. My original use case was from a RBF patch, where I was restaring the namenodes like this only, so kept the logic same
There was a problem hiding this comment.
I don't think that will repro the issue, Single restart shall pass only since all other namenodes are up. May be just one shutdown and the other one restarting will repro...
But that won't look good. My original use case was from a RBF patch, where I was restaring the namenodes like this only, so kept the logic same
Ah I see, yeah makes sense 👍
virajjasani
approved these changes
Dec 7, 2021
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
tomscut
approved these changes
Dec 12, 2021
|
Thanks for fixing it, @ayushtkn. Thanks for your review, @virajjasani and @tomscut. |
tasanuma
pushed a commit
that referenced
this pull request
Dec 14, 2021
…#3756) Reviewed-by: Viraj Jasani <[email protected]> Reviewed-by: litao <[email protected]> Signed-off-by: Takanobu Asanuma <[email protected]>
tasanuma
pushed a commit
that referenced
this pull request
Dec 14, 2021
…#3756) Reviewed-by: Viraj Jasani <[email protected]> Reviewed-by: litao <[email protected]> Signed-off-by: Takanobu Asanuma <[email protected]>
hotcodemacha
pushed a commit
to hotcodemacha/hadoop
that referenced
this pull request
Dec 22, 2021
…apache#3756) Reviewed-by: Viraj Jasani <[email protected]> Reviewed-by: litao <[email protected]> Signed-off-by: Takanobu Asanuma <[email protected]>
sunchao
pushed a commit
that referenced
this pull request
Jan 4, 2022
…#3756) Reviewed-by: Viraj Jasani <[email protected]> Reviewed-by: litao <[email protected]> Signed-off-by: Takanobu Asanuma <[email protected]>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…apache#3756) Reviewed-by: Viraj Jasani <[email protected]> Reviewed-by: litao <[email protected]> Signed-off-by: Takanobu Asanuma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes MiniDFSCluster namenode restart in case of multiple namenodes.
How was this patch tested?
Added UT
For code changes: