YARN-11107:When NodeLabel is enabled for a YARN cluster, AM blacklist… #4150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… program does not work properly.
|
💔 -1 overall
This message was automatically generated. |
brumi1024
requested changes
Apr 12, 2022
There was a problem hiding this comment.
Thanks for the patch @zhangxiping1! I had one comment, and can you please add a test (or extend an existing one i.e: in TestApplicationMasterService) for it?
Comment on lines
359
to
360
| } catch (Exception e){ | ||
| } |
There was a problem hiding this comment.
One thing about this: is the "queue missing" is a valid scenario here? If it is, and it's completely normal to not have any queue returned here, can you please write a comment (or a debug log line)? If it's not a valid scenario an exception could be thrown.
There was a problem hiding this comment.
Reference the SchedulerUtils. NormalizeAndValidateRequest fuction
try { queueInfo = rmContext.getScheduler().getQueueInfo(queueName, false, false); } catch (IOException e) { //Queue may not exist since it could be auto-created in case of // dynamic queues }
Should I add comments like this too？
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
@brumi1024 hi，Complete the test case ！
|
🎊 +1 overall
This message was automatically generated. |
brumi1024
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Thanks @zhangxiping1, after the updates the change looks good to me. I'll merge it today.
|
Merged to trunk. |
tasanuma
reviewed
Apr 15, 2022
| import org.apache.hadoop.yarn.util.resource.DominantResourceCalculator; | ||
| import org.apache.hadoop.yarn.util.resource.Resources; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; |
There was a problem hiding this comment.
Hi, @zhangxiping1 and @brumi1024.
We need to use thirdparty library for com.google.common.*.
import org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableMap;
There was a problem hiding this comment.
@tasanuma Thank you for your check. This PR has been closed. How should we deal with this situation?
There was a problem hiding this comment.
@zhangxiping1 Could you create another PR to fix it with the title of "YARN-11107. Addendum. When NodeLabel is enabled for a YARN cluster, AM blacklist program does not work properly."?
There was a problem hiding this comment.
OK ， created [(https://github.com//pull/4175)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… program does not work properly.
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?