MAPREDUCE-7422/MAPREDUCE-7428

[steveloughran]

Rollback of the changes trying to move mr to junit5 as tests were failing/being skipped.

• MAPREDUCE-7422 Upgrade Junit 4 to 5 in hadoop-mapreduce-examples (MAPREDUCE-7422. Upgrade Junit 4 to 5 in hadoop-mapreduce-examples #5029)
• MAPREDUCE-7428. Fix failures related to Junit 4 to Junit 5 upgrade in org.apache.hadoop.mapreduce.v2.app.webapp (MAPREDUCE-7428. Fix failures related to Junit 4 to Junit 5 upgrade in org.apache.hadoop.mapreduce.v2.app.webapp #5209)

if yetus is happy with test coverage will apply locally (so patches can go in independently)

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 7 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 7s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 48s		trunk passed
+1 💚	compile	2m 42s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	2m 19s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 13s		trunk passed
-1 ❌	javadoc	0m 40s	/branch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt	hadoop-mapreduce-client-app in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚	javadoc	1m 0s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	2m 2s		trunk passed
+1 💚	shadedclient	19m 50s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 51s		the patch passed
+1 💚	compile	2m 31s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	2m 31s		the patch passed
+1 💚	compile	2m 12s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	2m 12s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 53s	/results-checkstyle-hadoop-mapreduce-project.txt	hadoop-mapreduce-project: The patch generated 4 new + 68 unchanged - 2 fixed = 72 total (was 70)
+1 💚	mvnsite	0m 55s		the patch passed
-1 ❌	javadoc	0m 25s	/patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt	hadoop-mapreduce-client-app in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚	javadoc	0m 44s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	1m 53s		the patch passed
+1 💚	shadedclient	19m 37s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	9m 27s	/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt	hadoop-mapreduce-client-app in the patch passed.
+1 💚	unit	0m 49s		hadoop-mapreduce-examples in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		116m 46s

Reason	Tests
Failed junit tests	hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs
	hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts
	hadoop.mapreduce.v2.app.webapp.TestAMWebServices
	hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
	hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5239/1/artifact/out/Dockerfile
GITHUB PR	#5239
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 7e92ec4de3b1 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 866e36a
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5239/1/testReport/
Max. process+thread count	738 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5239/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[steveloughran]

getting test failures here. is there anything else which is needed/causing this

hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobs
hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempts
hadoop.mapreduce.v2.app.webapp.TestAMWebServices
hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
hadoop.mapreduce.v2.app.webapp.TestAMWebServicesJobConf

[aajisaka]

Should we revert YARN-6946 and MAPREDUCE-7428?

reference: https://issues.apache.org/jira/browse/MAPREDUCE-7428?focusedCommentId=17649392&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17649392

[steveloughran]

lets get #5243 in; if it is the fix there's no need to roll back