HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads #5274

sauraank · 2023-01-04T15:27:08Z

Description of PR

Logged the errors at the info level with just the message. Added the stack at the Debug level. Not made any changes where error stack was not present and had only the message and parameters at Warn/INFO level.
Also, removed the case of multiple logging in case of prefetch. Moved the log one method above ReadBlock() (which was common for sync read thread and async prefetch thread) and logged it at ERROR level for the case of read.

How was this patch tested?

Logging levels of Error/info was tested locally by throwing errors in case of both cases of async prefetch and sync get calls for read separately. Then the unit test of ITestS3APrefetchingInputStream integration test ( testReadLargeFileFully) was used.
Finally done the integration test by mvn -Dparallel-tests clean verify in the eu-west-1 region.
Following is the result of the tests -
[INFO] Results:
[INFO]
[WARNING] Tests run: 1154, Failures: 0, Errors: 0, Skipped: 182
[INFO]
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M1:integration-test (sequential-integration-tests) @ hadoop-aws ---
[INFO] Results:
[INFO]
[WARNING] Tests run: 124, Failures: 0, Errors: 0, Skipped: 84
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (depcheck) @ hadoop-aws ---
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M1:verify (default-integration-test) @ hadoop-aws ---
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M1:verify (sequential-integration-tests) @ hadoop-aws ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:05 min
[INFO] Finished at: 2023-02-14T11:25:12Z
[INFO] Final Memory: 76M/1674M
[INFO] ------------------------------------------------------------------------

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…o level once.

hadoop-yetus · 2023-01-04T19:28:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 37s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 11s		trunk passed
+1 💚	compile	25m 47s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	22m 16s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	4m 2s		trunk passed
+1 💚	mvnsite	2m 28s		trunk passed
-1 ❌	javadoc	1m 8s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt	hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚	javadoc	1m 18s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	3m 54s		trunk passed
+1 💚	shadedclient	23m 47s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 24s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 32s		the patch passed
+1 💚	compile	24m 43s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	24m 43s		the patch passed
+1 💚	compile	21m 51s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	21m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 53s	/results-checkstyle-root.txt	root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	mvnsite	2m 24s		the patch passed
-1 ❌	javadoc	1m 0s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt	hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚	javadoc	1m 19s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	4m 7s		the patch passed
+1 💚	shadedclient	24m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 25s		hadoop-common in the patch passed.
+1 💚	unit	3m 1s		hadoop-aws in the patch passed.
+1 💚	asflicense	0m 54s		The patch does not generate ASF License warnings.
		239m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/1/artifact/out/Dockerfile
GITHUB PR	#5274
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 465c3f60a6e5 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6c81a1f`
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/1/testReport/
Max. process+thread count	2305 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-01-11T20:03:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	34m 0s		trunk passed
+1 💚	compile	25m 19s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	21m 41s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	3m 59s		trunk passed
+1 💚	mvnsite	2m 27s		trunk passed
-1 ❌	javadoc	1m 9s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt	hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚	javadoc	1m 19s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	3m 54s		trunk passed
+1 💚	shadedclient	26m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 51s		the patch passed
+1 💚	compile	24m 31s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	24m 31s		the patch passed
+1 💚	compile	21m 37s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	21m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 53s		the patch passed
+1 💚	mvnsite	2m 23s		the patch passed
-1 ❌	javadoc	0m 59s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt	hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚	javadoc	1m 18s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	4m 3s		the patch passed
+1 💚	shadedclient	28m 6s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 21s		hadoop-common in the patch passed.
+1 💚	unit	2m 50s		hadoop-aws in the patch passed.
+1 💚	asflicense	0m 52s		The patch does not generate ASF License warnings.
		252m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/2/artifact/out/Dockerfile
GITHUB PR	#5274
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 9b24f24902f0 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2dd89ea`
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/2/testReport/
Max. process+thread count	3144 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

sauraank · 2023-02-02T11:16:58Z

Hey @steveloughran ! Can you please review it. Tested the logging of Errors by throwing errors in case of both prefetch and read.
Thanks

steveloughran

looks good, some minor nits to deal with and then it is good to go in.

It'll be interesting to see what happens in real use when we encounter errors here. With the prefetching things may surface sooner, but transient ones may now be recovered from better.

steveloughran · 2023-02-02T18:50:38Z

...ject/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/CachingBlockManager.java

-      readBlock(data, false, BufferData.State.BLANK);
+      try {
+        readBlock(data, false, BufferData.State.BLANK);
+      } catch(Exception e) {


add a space between catch and "(", and only catch IOException

steveloughran · 2023-02-02T18:52:15Z

...ject/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/CachingBlockManager.java

+        readBlock(data, false, BufferData.State.BLANK);
+      } catch(Exception e) {
+        String message = String.format("error reading block %s", data.getBlockNumber());
+        LOG.error(message, e);


the string formatting can go into the LOG.error() just like the ones below

sauraank · 2023-02-14T11:30:16Z

Hey @steveloughran ! Made the small changes recommended by you and ran the tests again. Thanks. Please review it.

steveloughran

LGTM
+1

steveloughran · 2023-02-14T11:41:55Z

will merge as soon as the yetus build is happy

hadoop-yetus · 2023-02-14T14:50:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 6s		Maven dependency ordering for branch
+1 💚	mvninstall	33m 41s		trunk passed
+1 💚	compile	25m 24s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	21m 48s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	4m 1s		trunk passed
+1 💚	mvnsite	2m 30s		trunk passed
+1 💚	javadoc	1m 37s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	1m 20s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	3m 53s		trunk passed
+1 💚	shadedclient	26m 37s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 52s		the patch passed
+1 💚	compile	24m 37s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	24m 37s		the patch passed
+1 💚	compile	21m 50s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	21m 50s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 53s		the patch passed
+1 💚	mvnsite	2m 27s		the patch passed
+1 💚	javadoc	1m 29s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	1m 19s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	4m 8s		the patch passed
+1 💚	shadedclient	26m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 10s		hadoop-common in the patch passed.
+1 💚	unit	2m 30s		hadoop-aws in the patch passed.
+1 💚	asflicense	0m 54s		The patch does not generate ASF License warnings.
		250m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/3/artifact/out/Dockerfile
GITHUB PR	#5274
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux aa75e4c3c81a 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a4a2d2e`
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/3/testReport/
Max. process+thread count	1239 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5274/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

sauraank · 2023-02-14T15:12:55Z

For test4tests,
Not written a separate test for it, but manually tested logging levels of Error/info locally by throwing errors in case of both cases of async prefetch and sync get calls for read separately. Thanks.

…reads (#5274) Contributed by Ankit Saurabh

…reads (apache#5274) Contributed by Ankit Saurabh

Ankit Saurabh and others added 5 commits November 21, 2022 14:17

Logged errors as info without stack trace for prefetching reads

e0c5ee8

changed error logging style for debug

b6d2d9c

Logged failures during Read at error level and during prefetch at inf…

6d01128

…o level once.

Addressed issues of throwing errors when read fails

3364461

Improved spacing and indentation

6c81a1f

Improved error message and checkstyle issue

2dd89ea

steveloughran requested changes Feb 2, 2023

View reviewed changes

Added space and and other minor changes

a4a2d2e

steveloughran approved these changes Feb 14, 2023

View reviewed changes

steveloughran self-assigned this Feb 14, 2023

steveloughran merged commit f4f2793 into apache:trunk Feb 15, 2023

ahmarsuhail mentioned this pull request Apr 17, 2023

HADOOP-18028. High performance S3A input stream (#4752) #5559

Closed

4 tasks

asfgit pushed a commit that referenced this pull request Apr 26, 2023

HADOOP-18351. Reduce excess logging of errors during S3A prefetching …

2c6f01c

…reads (#5274) Contributed by Ankit Saurabh

asfgit pushed a commit that referenced this pull request Apr 28, 2023

HADOOP-18351. Reduce excess logging of errors during S3A prefetching …

312b776

…reads (#5274) Contributed by Ankit Saurabh

ferdelyi pushed a commit to ferdelyi/hadoop that referenced this pull request May 26, 2023

HADOOP-18351. Reduce excess logging of errors during S3A prefetching …

576fbaa

…reads (apache#5274) Contributed by Ankit Saurabh

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads #5274

HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads #5274

Uh oh!

sauraank commented Jan 4, 2023 •

edited

Loading

Uh oh!

hadoop-yetus commented Jan 4, 2023

Uh oh!

hadoop-yetus commented Jan 11, 2023

Uh oh!

sauraank commented Feb 2, 2023

Uh oh!

steveloughran left a comment

Uh oh!

steveloughran Feb 2, 2023

Uh oh!

steveloughran Feb 2, 2023

Uh oh!

sauraank commented Feb 14, 2023 •

edited

Loading

Uh oh!

steveloughran left a comment

Uh oh!

steveloughran commented Feb 14, 2023

Uh oh!

hadoop-yetus commented Feb 14, 2023

Uh oh!

sauraank commented Feb 14, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads #5274

HADOOP-18351. Reduce excess logging of errors during S3A prefetching reads #5274

Uh oh!

Conversation

sauraank commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Jan 4, 2023

Uh oh!

hadoop-yetus commented Jan 11, 2023

Uh oh!

sauraank commented Feb 2, 2023

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

steveloughran Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

steveloughran Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

sauraank commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

steveloughran commented Feb 14, 2023

Uh oh!

hadoop-yetus commented Feb 14, 2023

Uh oh!

sauraank commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sauraank commented Jan 4, 2023 •

edited

Loading

sauraank commented Feb 14, 2023 •

edited

Loading

sauraank commented Feb 14, 2023 •

edited

Loading