HADOOP-18946. TestErrorTranslation failure

[steveloughran]

Remove invalid assertion

How was this patch tested?

Rerun of failing test suite.

Not. bothered with rest of tests

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[ayushtkn]

Change LGTM.

I have like 2 questions around this test class though.

• I am curious around this

    if (ioe.getCause() != thrown) {
      throw new AssertionError("Cause of " + ioe + " is not " + thrown, thrown);
    }

Why not?

    Assertions.assertThat(ioe.getCause()).isEqualTo(thrown);

• Why throws here? I think it isn't required

  public void testMultiObjectExceptionFilledIn() throws Throwable {

[steveloughran]

1. I want to throw that nested exception, as it is clearly something bad
2. just my IDE's "test" macro adds it always. and it means if we add more lines, no need to change the signature. matters more with subclasses