Skip to content

Conversation

pjfanning
Copy link
Member

Description of PR

HADOOP-18936

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 5m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 14m 55s Maven dependency ordering for branch
+1 💚 mvninstall 22m 41s branch-3.3 passed
+1 💚 compile 12m 4s branch-3.3 passed
+1 💚 mvnsite 19m 31s branch-3.3 passed
+1 💚 javadoc 4m 57s branch-3.3 passed
+1 💚 shadedclient 27m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 55s Maven dependency ordering for patch
+1 💚 mvninstall 22m 2s the patch passed
+1 💚 compile 11m 31s the patch passed
+1 💚 javac 11m 31s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 15m 3s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 4m 48s the patch passed
+1 💚 shadedclient 28m 26s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 110m 24s /patch-unit-root.txt root in the patch failed.
+0 🆗 asflicense 0m 24s ASF License check generated no output?
294m 48s
Reason Tests
Failed junit tests hadoop.hdfs.TestListFilesInDFS
hadoop.hdfs.TestMissingBlocksAlert
hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized
hadoop.hdfs.TestPread
hadoop.hdfs.TestHdfsAdmin
hadoop.hdfs.TestReconstructStripedFileWithValidator
hadoop.hdfs.TestEncryptedTransfer
hadoop.hdfs.TestDFSFinalize
hadoop.hdfs.TestSetrepDecreasing
hadoop.hdfs.TestDistributedFileSystemWithECFile
hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
hadoop.hdfs.TestFileAppendRestart
hadoop.hdfs.TestDecommissionWithBackoffMonitor
hadoop.hdfs.TestDFSInputStreamBlockLocations
hadoop.hdfs.TestFSOutputSummer
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6239/1/artifact/out/Dockerfile
GITHUB PR #6239
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 502c39900e27 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / a641254
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6239/1/testReport/
Max. process+thread count 2298 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6239/1/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 15m 6s Maven dependency ordering for branch
+1 💚 mvninstall 22m 21s branch-3.3 passed
+1 💚 compile 12m 4s branch-3.3 passed
+1 💚 mvnsite 19m 30s branch-3.3 passed
+1 💚 javadoc 4m 58s branch-3.3 passed
+1 💚 shadedclient 27m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 55s Maven dependency ordering for patch
+1 💚 mvninstall 22m 7s the patch passed
+1 💚 compile 11m 33s the patch passed
+1 💚 javac 11m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 15m 9s the patch passed
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 javadoc 4m 51s the patch passed
+1 💚 shadedclient 28m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 241m 48s /patch-unit-root.txt root in the patch failed.
+0 🆗 asflicense 0m 41s ASF License check generated no output?
420m 59s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.hdfs.server.federation.router.TestRouterFaultTolerant
hadoop.hdfs.server.federation.router.TestRouterNamenodeWebScheme
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6239/2/artifact/out/Dockerfile
GITHUB PR #6239
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 5069cb1c4b7c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / a641254
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6239/2/testReport/
Max. process+thread count 3614 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6239/2/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning
Copy link
Member Author

test failures due to OutOfMemoryError

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Failed tests pass locally

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.federation.router.TestRouterNamenodeWebScheme
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.925 s - in org.apache.hadoop.hdfs.server.federation.router.TestRouterNamenodeWebScheme
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 92.611 s - in org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.federation.router.TestRouterFaultTolerant
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.479 s - in org.apache.hadoop.hdfs.server.federation.router.TestRouterFaultTolerant
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.475 s - in org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

@ayushtkn ayushtkn merged commit b5276af into apache:branch-3.3 Nov 1, 2023
@pjfanning pjfanning deleted the HADOOP-18936-backport branch November 1, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants