Skip to content

Conversation

hiwangzhihui
Copy link
Contributor

@hiwangzhihui hiwangzhihui commented May 12, 2024

Description of PR

JIRA: HDFS-17522. JournalNode web interfaces lack configs for X-FRAME-OPTIONS protection.

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 01s No case conflicting files found.
+0 🆗 spotbugs 0m 00s spotbugs executables are not available.
+0 🆗 codespell 0m 00s codespell was not available.
+0 🆗 detsecrets 0m 00s detect-secrets was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 93m 21s trunk passed
+1 💚 compile 6m 17s trunk passed
+1 💚 checkstyle 5m 02s trunk passed
+1 💚 mvnsite 6m 54s trunk passed
+1 💚 javadoc 6m 32s trunk passed
+1 💚 shadedclient 153m 56s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 53s the patch passed
+1 💚 compile 3m 44s the patch passed
+1 💚 javac 3m 44s the patch passed
-1 ❌ blanks 0m 00s /blanks-eol.txt The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 checkstyle 2m 35s the patch passed
+1 💚 mvnsite 4m 35s the patch passed
+1 💚 javadoc 3m 41s the patch passed
+1 💚 shadedclient 165m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 5m 42s The patch does not generate ASF License warnings.
440m 54s
Subsystem Report/Notes
GITHUB PR #6814
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname MINGW64_NT-10.0-17763 53b71b4f2f76 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 213e3fc
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6814/1/testReport/
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6814/1/console
versions git=2.45.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 slfan1989 changed the title HDFS-17522. JournalNode web interfaces lack configs for X-FRAME-OPTIO… HDFS-17522. JournalNode web interfaces lack configs for X-FRAME-OPTIONS protection May 12, 2024
@hiwangzhihui hiwangzhihui force-pushed the trunk-for-HDFS-17522 branch from 213e3fc to c2bd098 Compare May 13, 2024 01:55
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 01s No case conflicting files found.
+0 🆗 spotbugs 0m 00s spotbugs executables are not available.
+0 🆗 codespell 0m 00s codespell was not available.
+0 🆗 detsecrets 0m 00s detect-secrets was not available.
+1 💚 @author 0m 01s The patch does not contain any @author tags.
+1 💚 test4tests 0m 00s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 88m 18s trunk passed
+1 💚 compile 6m 10s trunk passed
+1 💚 checkstyle 4m 40s trunk passed
+1 💚 mvnsite 6m 27s trunk passed
+1 💚 javadoc 5m 47s trunk passed
+1 💚 shadedclient 146m 46s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 29s the patch passed
+1 💚 compile 3m 19s the patch passed
+1 💚 javac 3m 19s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 checkstyle 2m 19s the patch passed
+1 💚 mvnsite 3m 57s the patch passed
+1 💚 javadoc 3m 25s the patch passed
+1 💚 shadedclient 152m 03s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 5m 11s The patch does not generate ASF License warnings.
414m 19s
Subsystem Report/Notes
GITHUB PR #6814
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname MINGW64_NT-10.0-17763 9c2306291c59 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / c2bd098
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6814/2/testReport/
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6814/2/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1.

@Hexiaoqiao Hexiaoqiao merged commit 12e0ca6 into apache:trunk May 13, 2024
@Hexiaoqiao
Copy link
Contributor

Committed to trunk. Thanks @hiwangzhihui and @vinayakumarb .

K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
…NS protection (apache#6814). Contributed by wangzhihui.

Signed-off-by: Vinayakumar B <[email protected]>
Signed-off-by: He Xiaoqiao <[email protected]>
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
…NS protection (apache#6814). Contributed by wangzhihui.

Signed-off-by: Vinayakumar B <[email protected]>
Signed-off-by: He Xiaoqiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants