Skip to content

Conversation

steveloughran
Copy link
Contributor

@steveloughran steveloughran commented May 13, 2024

+remove reference in LICENSE-binary as it is no longer shipped

tests in progress; for v1 update in trunk, as it isn't used except in tests for reflection-based support of v1 credential providers, we don't need the full CLI qualification

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

+remove reference in LICENSE-binary as it is no longer shipped

Change-Id: I3bb13e5e6b7b74bb59d3b4ddcf2027a1d97d2038
@steveloughran
Copy link
Contributor Author

steveloughran commented May 13, 2024

test run, two failures

[ERROR]   ITestS3ACommitterFactory.testEverything:115->testInvalidFileBinding:165 Expected a org.apache.hadoop.fs.s3a.commit.PathCommitException to be thrown, but got the result: : FileOutputCommitter{PathOutputCommitter{context=TaskAttemptContextImpl{JobContextImpl{jobId=job_202405130142_0004}; taskId=attempt_202405130142_0004_m_000000_0, status=''}; org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter@5b01c9de}; outputPath=s3a://stevel-london/fork-0004/test/testEverything, workPath=s3a://stevel-london/fork-0004/test/testEverything/_temporary/1/_temporary/attempt_202405130142_0004_m_000000_0, algorithmVersion=1, skipCleanup=false, ignoreCleanupFailures=false}
[ERROR] Errors: 
[ERROR]   ITestS3AConfiguration.testS3SpecificSignerOverride:577 » SdkClient Unable to load region from any of the providers in the chain software.amazon.awssdk.regions.providers.DefaultAwsRegionProviderChain@54ba231b: [software.amazon.awssdk.regions.providers.SystemSettingsRegionProvider@2d441088: Unable to load region from system settings. Region must be specified either via environment variable (AWS_REGION) or  system property (aws.region)., software.amazon.awssdk.regions.providers.AwsProfileRegionProvider@5486875: No region provided in profile: default, software.amazon.awssdk.regions.providers.InstanceProfileRegionProvider@65e1d433: EC2 Metadata is disabled. Unable to retrieve region information from EC2 Metadata service.]

both are unrelated. I'm not sure if the testS3SpecificSignerOverride one is long standing or recent and based on my config as there's no region specified

@steveloughran
Copy link
Contributor Author

oh, it's just the STS builder issue

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 00s No case conflicting files found.
+0 🆗 codespell 0m 00s codespell was not available.
+0 🆗 detsecrets 0m 00s detect-secrets was not available.
+0 🆗 shellcheck 0m 01s Shellcheck was not available.
+0 🆗 shelldocs 0m 01s Shelldocs was not available.
+0 🆗 xmllint 0m 00s xmllint was not available.
+1 💚 @author 0m 01s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 00s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 15s Maven dependency ordering for branch
+1 💚 mvninstall 121m 54s trunk passed
+1 💚 compile 59m 46s trunk passed
-1 ❌ mvnsite 36m 04s /branch-mvnsite-root.txt root in trunk failed.
+1 💚 javadoc 24m 12s trunk passed
+1 💚 shadedclient 435m 53s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 3m 06s Maven dependency ordering for patch
+1 💚 mvninstall 109m 07s the patch passed
+1 💚 compile 51m 05s the patch passed
+1 💚 javac 51m 05s the patch passed
+1 💚 blanks 0m 01s The patch has no blanks issues.
-1 ❌ mvnsite 30m 19s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 javadoc 22m 15s the patch passed
+1 💚 shadedclient 258m 04s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 10m 27s The patch does not generate ASF License warnings.
882m 35s
Subsystem Report/Notes
GITHUB PR #6823
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint
uname MINGW64_NT-10.0-17763 4becb5fa56c6 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 0bf5068
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6823/1/testReport/
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6823/1/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor Author

@mukund-thakur @ahmarsuhail can I get some review of this. now we don't ship this, it's low risk

Copy link
Contributor

@ahmarsuhail ahmarsuhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@virajjasani
Copy link
Contributor

+1 (non-binding)

@steveloughran steveloughran merged commit cfdf1f5 into apache:trunk May 15, 2024
asfgit pushed a commit that referenced this pull request May 15, 2024
+remove reference in LICENSE-binary as it is no longer shipped

Contributed by Steve Loughran

Change-Id: I0c17fdfe7d6e73114760c638f7149f5fd3d986ed
steveloughran added a commit to steveloughran/hadoop that referenced this pull request May 15, 2024
Contributed by Steve Loughran

Change-Id: I0c17fdfe7d6e73114760c638f7149f5fd3d986ed
steveloughran added a commit that referenced this pull request May 16, 2024
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
+remove reference in LICENSE-binary as it is no longer shipped

Contributed by Steve Loughran
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
+remove reference in LICENSE-binary as it is no longer shipped

Contributed by Steve Loughran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants