YARN-11706. Make yarn rmadmin tool support failover function #6957
+65
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granewang
changed the title
|
💔 -1 overall
This message was automatically generated. |
granewang
force-pushed
the
feature/YARN-11706
branch
from
c09e59d to
8a4f048
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
granewang
force-pushed
the
feature/YARN-11706
branch
from
10efb5c to
b350b8b
Compare
|
Fix blanks eol,while the checkstyle error is keeping with the legacy code,the legacy code checkstyle fixed pr:#6958 |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
zeekling
reviewed
Aug 7, 2024
| private final static Map<String, UsageInfo> YARN_HA_USAGE = | ||
| ImmutableMap.<String, UsageInfo> builder() | ||
| .put("-failover", new UsageInfo( | ||
| "<serviceId> <serviceId>", |
There was a problem hiding this comment.
Thanks for review ,
USAGE from HAAdmin.java does not contain usage and help information about failover,so YARN_HA_USAGE structure is added here for appending these information
| HAServiceProtocolHelper.transitionToStandby(proto, createReqInfo()); | ||
| HAServiceProtocol proto1 = toNode.getProxy( | ||
| getConf(), 0); | ||
| HAServiceProtocolHelper.transitionToActive(proto1, createReqInfo()); |
There was a problem hiding this comment.
Do we need to check whether args[1] is the primary? If it is the primary, there is no need to switch.
There was a problem hiding this comment.
If args[1] is the primary,it will return ：
HAServiceProtocolHelper.transitionToActive ->AdminService.java(transitionToActive):
"
@OverRide
public synchronized void transitionToActive(
HAServiceProtocol.StateChangeRequestInfo reqInfo) throws IOException {
if (isRMActive()) {
return;
}
....
"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Currently,yarn rmadmin can not support failover,This failover step is just the same as step :
yarn rmadmin -transitionToStandby -forcemanual rm1
yarn rmadmin -transitionToActive -forcemanual rm2
How was this patch tested?
change the active node from rm1 to rm2:
yarn rmadmin -failover rm1 rm2