Skip to content

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jul 25, 2024

Description of PR

HADOOP-19237 - replaces #6955

https://github.com/dnsjava/dnsjava/blob/master/Changelog

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 15s Maven dependency ordering for branch
+1 💚 mvninstall 36m 37s trunk passed
+1 💚 compile 19m 0s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 16m 34s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 checkstyle 4m 43s trunk passed
+1 💚 mvnsite 23m 37s trunk passed
+1 💚 javadoc 8m 52s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 6s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 18s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 33m 14s /branch-spotbugs-root-warnings.html root in trunk has 2 extant spotbugs warnings.
+1 💚 shadedclient 69m 1s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
-1 ❌ mvninstall 19m 52s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 18m 10s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 18m 10s the patch passed
+1 💚 compile 17m 19s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 17m 19s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 4m 7s the patch passed
+1 💚 mvnsite 15m 55s the patch passed
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 javadoc 8m 38s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 3s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 20s hadoop-project has no data from spotbugs
-1 ❌ shadedclient 57m 13s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 760m 35s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 18s The patch does not generate ASF License warnings.
1121m 12s
Reason Tests
Failed junit tests hadoop.registry.server.dns.TestSecureRegistryDNS
hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/1/artifact/out/Dockerfile
GITHUB PR #6961
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname Linux d3dac28b6af3 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2e2773e
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/1/testReport/
Max. process+thread count 3685 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-registry . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning
Copy link
Contributor Author

There are still some issues.

  • dnsjava 3.6.0 has some classes in META-INF/versions that are causing issues with maven-shade-plugin
  • org.apache.hadoop.registry.server.dns.TestSecureRegistryDNS tests break - the code changes in this PR are not the issue - the issue is a change in dnsjava 3.6.0 - the tests pass with dnsjava 3.5.3 (the previous release)

@pjfanning pjfanning marked this pull request as draft July 26, 2024 09:28
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 26s Maven dependency ordering for branch
+1 💚 mvninstall 37m 40s trunk passed
+1 💚 compile 19m 45s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 17m 36s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 checkstyle 4m 37s trunk passed
+1 💚 mvnsite 22m 53s trunk passed
+1 💚 javadoc 9m 0s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 1s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 18s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 19s branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 32m 43s /branch-spotbugs-root-warnings.html root in trunk has 2 extant spotbugs warnings.
+1 💚 shadedclient 71m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
-1 ❌ mvninstall 35m 3s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 18m 47s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 18m 47s the patch passed
+1 💚 compile 17m 50s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 17m 50s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 4m 33s the patch passed
+1 💚 mvnsite 19m 51s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 9m 15s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 9m 13s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 19s hadoop-project has no data from spotbugs
+0 🆗 spotbugs 0m 20s hadoop-client-modules/hadoop-client-runtime has no data from spotbugs
-1 ❌ shadedclient 73m 37s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 720m 15s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 22s The patch does not generate ASF License warnings.
1132m 53s
Reason Tests
Unreaped Processes root:2
Failed junit tests hadoop.registry.server.dns.TestSecureRegistryDNS
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/2/artifact/out/Dockerfile
GITHUB PR #6961
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname Linux 0fa24427157f 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f086d8f
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Unreaped Processes Log https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/2/artifact/out/patch-unit-root-reaper.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/2/testReport/
Max. process+thread count 3570 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-registry hadoop-client-modules/hadoop-client-runtime . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 21s Maven dependency ordering for branch
+1 💚 mvninstall 37m 31s trunk passed
+1 💚 compile 20m 13s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 18m 43s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 checkstyle 4m 58s trunk passed
+1 💚 mvnsite 26m 22s trunk passed
+1 💚 javadoc 8m 52s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 9s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 19s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 20s branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 32m 32s /branch-spotbugs-root-warnings.html root in trunk has 2 extant spotbugs warnings.
+1 💚 shadedclient 69m 13s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
-1 ❌ mvninstall 32m 25s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 17m 25s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 17m 25s the patch passed
+1 💚 compile 16m 5s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 16m 5s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 43s the patch passed
+1 💚 mvnsite 19m 28s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 55s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 7m 57s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 19s hadoop-project has no data from spotbugs
+0 🆗 spotbugs 0m 21s hadoop-client-modules/hadoop-client-runtime has no data from spotbugs
-1 ❌ shadedclient 69m 40s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 663m 43s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 5s The patch does not generate ASF License warnings.
1066m 19s
Reason Tests
Unreaped Processes root:2
Failed junit tests hadoop.registry.server.dns.TestSecureRegistryDNS
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/3/artifact/out/Dockerfile
GITHUB PR #6961
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname Linux ed86f2b1bdef 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f055f93
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Unreaped Processes Log https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/3/artifact/out/patch-unit-root-reaper.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/3/testReport/
Max. process+thread count 3834 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-registry hadoop-client-modules/hadoop-client-runtime . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 33s Maven dependency ordering for branch
+1 💚 mvninstall 35m 45s trunk passed
+1 💚 compile 18m 13s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 16m 12s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 checkstyle 4m 41s trunk passed
+1 💚 mvnsite 25m 58s trunk passed
+1 💚 javadoc 8m 53s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 8s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 18s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 19s branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 32m 40s /branch-spotbugs-root-warnings.html root in trunk has 2 extant spotbugs warnings.
+1 💚 shadedclient 68m 11s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
-1 ❌ mvninstall 32m 11s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 18m 19s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 18m 19s the patch passed
+1 💚 compile 16m 44s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 16m 44s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 45s the patch passed
+1 💚 mvnsite 16m 30s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 54s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 7s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 18s hadoop-project has no data from spotbugs
+0 🆗 spotbugs 0m 18s hadoop-client-modules/hadoop-client-runtime has no data from spotbugs
-1 ❌ shadedclient 68m 52s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 764m 11s root in the patch passed.
+1 💚 asflicense 1m 20s The patch does not generate ASF License warnings.
1158m 28s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/4/artifact/out/Dockerfile
GITHUB PR #6961
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname Linux ac71c347cfa4 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / cb5fbda
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/4/testReport/
Max. process+thread count 3638 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-registry hadoop-client-modules/hadoop-client-runtime . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 27s Maven dependency ordering for branch
+1 💚 mvninstall 36m 43s trunk passed
+1 💚 compile 19m 32s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 18m 14s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 checkstyle 4m 52s trunk passed
+1 💚 mvnsite 28m 7s trunk passed
+1 💚 javadoc 9m 5s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 8m 29s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 40s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 19s branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 17s branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 34m 5s /branch-spotbugs-root-warnings.html root in trunk has 2 extant spotbugs warnings.
+1 💚 shadedclient 69m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
+1 💚 mvninstall 38m 1s the patch passed
+1 💚 compile 17m 55s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 17m 55s the patch passed
+1 💚 compile 17m 0s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 17m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 29s the patch passed
+1 💚 mvnsite 18m 59s the patch passed
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 javadoc 8m 46s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 7m 56s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+0 🆗 spotbugs 0m 20s hadoop-project has no data from spotbugs
+0 🆗 spotbugs 0m 20s hadoop-client-modules/hadoop-client-runtime has no data from spotbugs
+0 🆗 spotbugs 0m 18s hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs
+1 💚 shadedclient 69m 40s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 764m 4s root in the patch passed.
+1 💚 asflicense 1m 26s The patch does not generate ASF License warnings.
1167m 47s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/5/artifact/out/Dockerfile
GITHUB PR #6961
Optional Tests dupname asflicense mvnsite unit shadedclient codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall xmllint spotbugs checkstyle
uname Linux a9e28a442326 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 93bca44
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/5/testReport/
Max. process+thread count 3640 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-registry hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-check-invariants . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6961/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning pjfanning changed the title HADOOP-19237. Upgrade to dnsjava 3.6.0 due to CVEs HADOOP-19237. Upgrade to dnsjava 3.6.1 due to CVEs Jul 31, 2024
@pjfanning pjfanning marked this pull request as ready for review July 31, 2024 20:37
@pjfanning
Copy link
Contributor Author

@ayushtkn @slfan1989 @steveloughran would any of you have time to review this change? There were a few code changes to get Hadoop code to work with the newer jar but nothing major.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

@steveloughran steveloughran merged commit c593c17 into apache:trunk Aug 1, 2024
1 of 4 checks passed
@steveloughran
Copy link
Contributor

merged. who wants to do the branch 3.4 pr?

@pjfanning pjfanning deleted the HADOOP-19237-dnsjava branch August 1, 2024 19:32
pjfanning added a commit to pjfanning/hadoop that referenced this pull request Aug 1, 2024
@pjfanning
Copy link
Contributor Author

merged. who wants to do the branch 3.4 pr?

#6971 done

ayushtkn pushed a commit that referenced this pull request Aug 3, 2024
@ShibasishDelphix
Copy link

Hello team,
Could you please confirm when 3.4.1 is planned to release which will have this fix?

@steveloughran
Copy link
Contributor

@ShibasishDelphix this is something @mukund-thakur is working on; arm64 docker builds are the current pain point. Anything you can do to help that would be wonderful.

If you subscribe to the hadoop common developer list you could also get involved in testing the release candidates. This is an absolutely critical contribution -and you would benefit as if there aren't any integration problems in your environment you would get them fixed within a few days.

mukund-thakur pushed a commit that referenced this pull request Aug 12, 2024
@mukund-thakur
Copy link
Contributor

Push this to branch-3.4.1 just now, https://github.com/apache/hadoop/commits/branch-3.4.1/
And yes it would be really helpful to get some RC1 validation which I created last week. Thanks

KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Sep 9, 2024
Hexiaoqiao pushed a commit to Hexiaoqiao/hadoop that referenced this pull request Sep 12, 2024
DremioQA pushed a commit to dremio/hadoop that referenced this pull request Mar 6, 2025
Change-Id: I0054f82bc72b928c3570d3205d230355f7c19a1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants