Skip to content

Conversation

pjfanning
Copy link
Contributor

New class org.apache.hadoop.util.JacksonUtil centralizes construction of Jackson ObjectMappers and JsonFactories.

Description of PR

Backport #6953

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

New class org.apache.hadoop.util.JacksonUtil centralizes construction of
Jackson ObjectMappers and JsonFactories.

Contributed by PJ Fanning

merge issues
@pjfanning pjfanning mentioned this pull request Aug 15, 2024
4 tasks
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 4m 24s Maven dependency ordering for branch
+1 💚 mvninstall 41m 17s branch-3.4 passed
+1 💚 compile 17m 30s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 16m 16s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 37s branch-3.4 passed
+1 💚 mvnsite 18m 44s branch-3.4 passed
+1 💚 javadoc 15m 48s branch-3.4 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 15m 38s branch-3.4 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
-1 ❌ spotbugs 2m 44s /branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html hadoop-hdfs-project/hadoop-hdfs-client in branch-3.4 has 1 extant spotbugs warnings.
-1 ❌ spotbugs 1m 2s /branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs-warnings.html hadoop-hdfs-project/hadoop-hdfs-httpfs in branch-3.4 has 1 extant spotbugs warnings.
-1 ❌ spotbugs 1m 13s /branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core-warnings.html hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core in branch-3.4 has 1 extant spotbugs warnings.
+1 💚 shadedclient 34m 26s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 mvninstall 10m 54s the patch passed
+1 💚 compile 16m 58s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 16m 58s the patch passed
+1 💚 compile 16m 24s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 16m 24s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 26s root: The patch generated 0 new + 638 unchanged - 6 fixed = 638 total (was 644)
+1 💚 mvnsite 18m 25s the patch passed
+1 💚 javadoc 16m 0s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 15m 45s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 32m 34s the patch passed
+1 💚 shadedclient 34m 6s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 37s hadoop-common in the patch passed.
+1 💚 unit 3m 54s hadoop-kms in the patch passed.
+1 💚 unit 2m 46s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 218m 32s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 6m 24s hadoop-hdfs-httpfs in the patch passed.
+1 💚 unit 6m 4s hadoop-yarn-common in the patch passed.
+1 💚 unit 4m 44s hadoop-yarn-server-applicationhistoryservice in the patch passed.
+1 💚 unit 2m 10s hadoop-yarn-server-timelineservice in the patch passed.
+1 💚 unit 102m 48s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 unit 24m 43s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 unit 8m 43s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 5m 3s hadoop-yarn-server-timeline-pluginstorage in the patch passed.
+1 💚 unit 1m 15s hadoop-yarn-server-timelineservice-documentstore in the patch passed.
+1 💚 unit 21m 47s hadoop-yarn-services-core in the patch passed.
+1 💚 unit 1m 28s hadoop-yarn-applications-catalog-webapp in the patch passed.
+1 💚 unit 0m 53s hadoop-dynamometer-infra in the patch passed.
+1 💚 unit 0m 55s hadoop-rumen in the patch passed.
+1 💚 unit 2m 53s hadoop-azure in the patch passed.
+1 💚 unit 12m 46s hadoop-sls in the patch passed.
+1 💚 asflicense 1m 16s The patch does not generate ASF License warnings.
832m 32s
Reason Tests
Failed junit tests hadoop.hdfs.protocol.TestBlockListAsLongs
hadoop.hdfs.server.datanode.TestLargeBlockReport
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6998/1/artifact/out/Dockerfile
GITHUB PR #6998
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 08e894a46fb1 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 950a616
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6998/1/testReport/
Max. process+thread count 3559 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra hadoop-tools/hadoop-rumen hadoop-tools/hadoop-azure hadoop-tools/hadoop-sls U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6998/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning pjfanning marked this pull request as draft August 19, 2024 11:26
@pjfanning
Copy link
Contributor Author

Temporarily marking as draft because one of the CI builds is affected by #6953

@pjfanning pjfanning closed this Aug 30, 2024
@pjfanning pjfanning deleted the HADOOP-19231-backport branch August 30, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants