Skip to content

Conversation

zhengchenyu
Copy link
Contributor

@zhengchenyu zhengchenyu commented Aug 20, 2024

Description of PR

I submitted #6987 before, but in that PR, because the native code of hadoop common was not changed, "precommit-run Centos 7" was not triggered. Therefore, this unit test may still fail in some PRs. So I debugged in #6972 and solved this problem.

I found SIGINT was ignored before executing TestServiceInterruptHandling::testRegisterAndRaise. In the java code, for SIGHUP, SIGINT, and SIGTERM, if its SignalHandler have been set to SIG_IGN, any further actions to set SignalHandler will be invalid. For details, see jdk signal

In fact, it is difficult for me to reproduce this bug on my computer. But if I add Signal.handle(new Signal(IrqHandler.CONTROL_C), SignalHandler.SIG_IGN); in front of irqHandler.bind();, it can be reproduced stably, which also proves that what I said before is correct.

In order to further prove this problem on docker ci, I submitted commit, then will find the following error like this:

[ERROR] testRegisterAndRaise(org.apache.hadoop.service.launcher.TestServiceInterruptHandling)  Time elapsed: 0.017 s  <<< FAILURE!
java.lang.AssertionError: SIGINT have been ignored, so can not set signal handler.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)

It also proves that SIGINT was ignored.

Since SIGINT may be ignored, let's use USR2.

How was this patch tested?

docker ci

For code changes:

  • use signal USR2 instead of signal INT

@zhengchenyu zhengchenyu marked this pull request as draft August 20, 2024 12:23
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 45m 12s trunk passed
+1 💚 compile 16m 1s trunk passed
+1 💚 mvnsite 1m 48s trunk passed
+1 💚 shadedclient 96m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 1s the patch passed
+1 💚 compile 15m 35s the patch passed
+1 💚 cc 15m 35s the patch passed
+1 💚 golang 15m 35s the patch passed
+1 💚 javac 15m 35s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 47s the patch passed
+1 💚 shadedclient 35m 36s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 20m 15s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 asflicense 1m 8s The patch does not generate ASF License warnings.
172m 52s
Reason Tests
Failed junit tests hadoop.service.launcher.TestServiceInterruptHandling
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/1/artifact/out/Dockerfile
GITHUB PR #7008
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname Linux fb047f892cee 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / a0d0900
Default Java Red Hat, Inc.-1.8.0_412-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/1/testReport/
Max. process+thread count 3151 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/1/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 33m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 46m 15s trunk passed
+1 💚 compile 16m 6s trunk passed
+1 💚 checkstyle 1m 20s trunk passed
+1 💚 mvnsite 1m 48s trunk passed
+1 💚 javadoc 1m 5s trunk passed
+1 💚 spotbugs 2m 43s trunk passed
+1 💚 shadedclient 40m 6s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 2s the patch passed
+1 💚 compile 16m 5s the patch passed
+1 💚 cc 16m 5s the patch passed
+1 💚 golang 16m 5s the patch passed
+1 💚 javac 16m 5s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 17s the patch passed
+1 💚 mvnsite 1m 48s the patch passed
+1 💚 javadoc 0m 58s the patch passed
+1 💚 spotbugs 2m 51s the patch passed
+1 💚 shadedclient 35m 37s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 7s hadoop-common in the patch passed.
+1 💚 asflicense 1m 8s The patch does not generate ASF License warnings.
223m 10s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/2/artifact/out/Dockerfile
GITHUB PR #7008
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang javadoc mvninstall shadedclient spotbugs checkstyle
uname Linux 420d9e6e6e4a 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0da28f0
Default Java Red Hat, Inc.-1.8.0_412-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/2/testReport/
Max. process+thread count 3152 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/2/console
versions git=2.9.5 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 20m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 30m 18s trunk passed
+1 💚 compile 16m 8s trunk passed
+1 💚 checkstyle 1m 49s trunk passed
-1 ❌ mvnsite 1m 39s /branch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in trunk failed.
+1 💚 javadoc 1m 29s trunk passed
+1 💚 spotbugs 3m 11s trunk passed
+1 💚 shadedclient 37m 4s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 7s the patch passed
+1 💚 compile 15m 19s the patch passed
+1 💚 cc 15m 19s the patch passed
+1 💚 golang 15m 19s the patch passed
+1 💚 javac 15m 19s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 50s the patch passed
-1 ❌ mvnsite 1m 40s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 javadoc 1m 28s the patch passed
+1 💚 spotbugs 3m 22s the patch passed
+1 💚 shadedclient 39m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 20m 51s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
-1 ❌ asflicense 1m 30s /results-asflicense.txt The patch generated 3 ASF License warnings.
197m 53s
Reason Tests
Failed junit tests hadoop.io.file.tfile.TestTFileComparators
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/2/artifact/out/Dockerfile
GITHUB PR #7008
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang javadoc mvninstall shadedclient spotbugs checkstyle
uname Linux 5cabc8f01080 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0da28f0
Default Java Red Hat, Inc.-1.8.0_312-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/2/testReport/
Max. process+thread count 1936 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/2/console
versions git=2.27.0 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 31m 56s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 45m 19s trunk passed
+1 💚 compile 15m 4s trunk passed
+1 💚 checkstyle 1m 5s trunk passed
+1 💚 mvnsite 1m 39s trunk passed
+1 💚 javadoc 0m 55s trunk passed
+1 💚 spotbugs 2m 43s trunk passed
+1 💚 shadedclient 35m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 55s the patch passed
+1 💚 compile 15m 37s the patch passed
+1 💚 cc 15m 37s the patch passed
+1 💚 golang 15m 37s the patch passed
+1 💚 javac 15m 37s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 1m 2s the patch passed
+1 💚 mvnsite 1m 36s the patch passed
+1 💚 javadoc 0m 50s the patch passed
+1 💚 spotbugs 3m 13s the patch passed
+1 💚 shadedclient 39m 21s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 49s hadoop-common in the patch passed.
+1 💚 asflicense 0m 55s The patch does not generate ASF License warnings.
216m 6s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/3/artifact/out/Dockerfile
GITHUB PR #7008
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang javadoc mvninstall shadedclient spotbugs checkstyle
uname Linux 5da87c02f29e 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1953b5c
Default Java Red Hat, Inc.-1.8.0_412-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/3/testReport/
Max. process+thread count 3152 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/3/console
versions git=2.9.5 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhengchenyu zhengchenyu marked this pull request as ready for review August 21, 2024 03:56
@zhengchenyu
Copy link
Contributor Author

@steveloughran Hi, can you please review this PR?
cc @Hexiaoqiao the failed unit test in #6813 (comment) will fix in this pr.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 21m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 24s trunk passed
+1 💚 compile 16m 54s trunk passed
+1 💚 checkstyle 1m 26s trunk passed
-1 ❌ mvnsite 1m 19s /branch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in trunk failed.
+1 💚 javadoc 1m 8s trunk passed
+1 💚 spotbugs 2m 52s trunk passed
+1 💚 shadedclient 38m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 5s the patch passed
+1 💚 compile 16m 24s the patch passed
+1 💚 cc 16m 24s the patch passed
+1 💚 golang 16m 24s the patch passed
+1 💚 javac 16m 24s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 29s the patch passed
-1 ❌ mvnsite 1m 19s /patch-mvnsite-hadoop-common-project_hadoop-common.txt hadoop-common in the patch failed.
+1 💚 javadoc 1m 7s the patch passed
+1 💚 spotbugs 2m 57s the patch passed
+1 💚 shadedclient 35m 47s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 47s hadoop-common in the patch passed.
+1 💚 asflicense 1m 13s The patch does not generate ASF License warnings.
197m 37s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/3/artifact/out/Dockerfile
GITHUB PR #7008
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang javadoc mvninstall shadedclient spotbugs checkstyle
uname Linux d6ec020a9c82 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1953b5c
Default Java Red Hat, Inc.-1.8.0_312-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/3/testReport/
Max. process+thread count 3150 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/3/console
versions git=2.27.0 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 slfan1989 changed the title HADOOP-19250. Addendum. Fix test TestServiceInterruptHandling.testRegisterAndRaise HADOOP-19250. [Addendum] Fix test TestServiceInterruptHandling.testRegisterAndRaise. Aug 21, 2024
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but I'd like the followup to not include cutting a line for no obvious reason

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 46m 32s trunk passed
+1 💚 compile 17m 38s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 16m 6s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 1m 20s trunk passed
+1 💚 mvnsite 1m 44s trunk passed
+1 💚 javadoc 1m 17s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 56s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 2m 45s trunk passed
+1 💚 shadedclient 36m 7s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 57s the patch passed
+1 💚 compile 16m 53s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 cc 16m 53s the patch passed
+1 💚 golang 16m 53s the patch passed
+1 💚 javac 16m 53s the patch passed
+1 💚 compile 16m 20s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 cc 16m 20s the patch passed
+1 💚 golang 16m 20s the patch passed
+1 💚 javac 16m 20s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 15s the patch passed
+1 💚 mvnsite 1m 41s the patch passed
+1 💚 javadoc 1m 14s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 58s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 2m 49s the patch passed
+1 💚 shadedclient 36m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 44s hadoop-common in the patch passed.
+1 💚 asflicense 1m 6s The patch does not generate ASF License warnings.
225m 37s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/4/artifact/out/Dockerfile
GITHUB PR #7008
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang javadoc mvninstall shadedclient spotbugs checkstyle
uname Linux eb039f3bc562 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 83fb5d4
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/4/testReport/
Max. process+thread count 1252 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7008/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran merged commit 1655acc into apache:trunk Aug 30, 2024
4 checks passed
@steveloughran
Copy link
Contributor

merged and updated the jira to make clear both PRs should be cherrypicked.

do you want to do a PR chain which does that for branch-3.4?

zhengchenyu added a commit to zhengchenyu/hadoop that referenced this pull request Aug 30, 2024
@zhengchenyu zhengchenyu deleted the HADOOP-19250.Addendum branch August 30, 2024 11:51
@zhengchenyu
Copy link
Contributor Author

merged and updated the jira to make clear both PRs should be cherrypicked.

do you want to do a PR chain which does that for branch-3.4?

@steveloughran OK, I have create #7020 to branch-3.4

KeeProMise pushed a commit to KeeProMise/hadoop that referenced this pull request Sep 9, 2024
Hexiaoqiao pushed a commit to Hexiaoqiao/hadoop that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants