HDFS-17761. [ARR] RouterNetworkTopologyServlet adapts to async router rpc. #7533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfutatzhanghb
force-pushed
the
HDFS-17761
branch
from
e538f20 to
af2df38
Compare
|
@KeeProMise Could you please help review this pr when have free time? |
|
🎊 +1 overall
This message was automatically generated. |
|
The checkstyle problem was caused by #7535 , which has been reverted. 
|
|
🎊 +1 overall
This message was automatically generated. |
KeeProMise
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Hi @hfutatzhanghb Thanks for your contribution. Leave some comments.
.../main/java/org/apache/hadoop/hdfs/server/federation/router/RouterNetworkTopologyServlet.java
Show resolved
Hide resolved
...t/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNetworkTopologyServlet.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
KeeProMise
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
LGTM! hi @slfan1989 If you have time, please help review the unit test.
@KeeProMise Thank you for inviting me to review this PR! I will check the related unit tests as soon as possible. We are in the process of upgrading the HDFS Router to JUnit5, and one PR has already been merged, while another PR (#7531) has been approved. Once #7531 is merged, I plan to monitor it for 1-2 days to ensure everything is working correctly, and then we will merge this PR. Therefore, the merge of this PR may be delayed until this weekend or early next week. cc: @hfutatzhanghb |
|
No problems! Thanks @slfan1989 @KeeProMise . |
hfutatzhanghb
force-pushed
the
HDFS-17761
branch
from
820b870 to
85f28de
Compare
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Mar 31, 2025
...t/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNetworkTopologyServlet.java
Show resolved
Hide resolved
slfan1989
reviewed
Apr 2, 2025
| } | ||
| } | ||
|
|
||
| class RouterServerHelper implements BeforeEachCallback, AfterAllCallback { |
There was a problem hiding this comment.
I have a question. Shouldn't RouterServerHelper be extracted from this class and made into a separate utility class?
There was a problem hiding this comment.
Hi, @slfan1989 . Actually, I'd ever consider this way, but i found each test class have its own initialize logic. For example, some test class may need mkdis or addMountPoints which is unused for other test class. What's your opinions?
There was a problem hiding this comment.
I believe the current changes in this PR are acceptable, but it would be better to extract RouterServerHelper to avoid potential code redundancy.
There was a problem hiding this comment.
Maybe we can merge this firstly and i will try to extract common logic in #7470 ?
There was a problem hiding this comment.
@KeeProMise Do you have any other suggestions? We can take a look at the details in #7470 first. If you think there are no issues, we can merge this PR anytime. Thanks again!
There was a problem hiding this comment.
@hfutatzhanghb @slfan1989 LGTM.
slfan1989
approved these changes
Apr 2, 2025
|
@hfutatzhanghb Thanks for your contribution, @slfan1989 thanks for your review. merged! |
|
Thanks all for reviewing and merging!!! |
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Apr 4, 2025
… rpc. (apache#7533). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <[email protected]> Reviewed-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
RouterNetworkTopologyServlet adapts to async router rpc.
Currently, we will get NPE when request RouterNetworkTopologyServlet using async router rpc. Logs as below:
How was this patch tested?
Add an unit test.