HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13. #7890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leosanqing
reviewed
Aug 21, 2025
| @@ -445,8 +445,8 @@ public static void assertFileContentsDifferent( | |||
| public static Map<File, String> getFileMD5s(File... files) throws Exception { | |||
| Map<File, String> ret = Maps.newHashMap(); | |||
| for (File f : files) { | |||
| assertTrue("Must exist: " + f, f.exists()); | |||
| ret.put(f, getFileMD5(f)); | |||
| assertTrue(f.exists(), "Must exist: " + f); | |||
There was a problem hiding this comment.
Hi, it looks like there might be an extra indent here.
There was a problem hiding this comment.
Thank you very much for the review—I’ll update the code as soon as possible.
slfan1989
reviewed
Aug 21, 2025
| @@ -22,7 +22,7 @@ | |||
| import static org.apache.hadoop.fs.permission.AclEntryScope.*; | |||
| import static org.apache.hadoop.fs.permission.AclEntryType.*; | |||
| import static org.apache.hadoop.fs.permission.FsAction.*; | |||
| import static org.junit.Assert.*; | |||
| import static org.junit.jupiter.api.Assertions.*; | |||
There was a problem hiding this comment.
Thanks for the review! I’ll push the updates shortly.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Aug 24, 2025
| @@ -53,12 +51,12 @@ | |||
| import java.util.Set; | |||
| import java.util.concurrent.atomic.AtomicInteger; | |||
|
|
|||
| import static org.junit.Assert.assertThat; | |||
|
|
|||
There was a problem hiding this comment.
The line can be removed.
slfan1989
reviewed
Aug 24, 2025
| @BeforeClass | ||
| public static void init() throws Exception { | ||
| @BeforeAll | ||
| public static void init() throws Exception { |
There was a problem hiding this comment.
Thank you for the review. I’ll roll out the updates soon.
slfan1989
approved these changes
Aug 24, 2025
|
@zhtttylz Thanks for the contribution! The PR looks good overall, but we need to fix the checkstyle issues. |
zhtttylz
force-pushed
the
hadoop-hdfs-part13
branch
from
a59bfe5 to
8395289
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@zhtttylz Thanks for the contribution! Merged into trunk. |
|
Thanks @slfan1989 for reviewing and merging! |
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part13.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?