HDDS-1550. MiniOzoneCluster is not shutting down all the threads during shutdown. Contributed by Mukul Kumar Singh. #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during shutdown. Contributed by Mukul Kumar Singh.
mukul1987
changed the title
|
💔 -1 overall
This message was automatically generated. |
jiwq
reviewed
May 17, 2019
| try { | ||
| executorService.awaitTermination(1, TimeUnit.DAYS); | ||
| } catch (Exception e) { | ||
| LOG.error("failed to shutdown Report Manager", e); |
There was a problem hiding this comment.
The first letter of the first word as a capital letter maybe better.
There was a problem hiding this comment.
Do you want timeUnit to be Days?
| private final OzoneConfiguration configuration; | ||
| private final SafeModeHandler safeModeHandler; | ||
| private SCMContainerMetrics scmContainerMetrics; | ||
| private MetricsSystem ms; |
There was a problem hiding this comment.
Suggest modify the instance variable name, so that it readability.
| conf.setTimeDuration(HddsConfigKeys.HDDS_HEARTBEAT_INTERVAL, 1, | ||
| TimeUnit.SECONDS); | ||
| conf.setInt(OzoneConfigKeys.OZONE_CONTAINER_CACHE_SIZE, 8); | ||
| conf.setInt(OzoneConfigKeys.OZONE_CONTAINER_CACHE_SIZE, 2); |
There was a problem hiding this comment.
What's the purpose of change the cache size?
| if (isStarted) { | ||
| server.shutdown(); | ||
| try { | ||
| server.awaitTermination(1, TimeUnit.DAYS); |
There was a problem hiding this comment.
It's better to read the value from configuration file.
There was a problem hiding this comment.
Same question as above.
|
Thanks @mukul1987 for working on this. i am +1 on this. The patch looks good to me. Please address @jiwq comments, while committing. |
ajayydv
reviewed
May 21, 2019
| metrics.unRegister(); | ||
| } | ||
|
|
||
| if (ms != null) { |
There was a problem hiding this comment.
in order of precedence, i think closing scmMetadataStore takes more precedence than Metrics. Shall we move this close statement to end.
| LOG.info("Shutting the HddsDatanodes"); | ||
| hddsDatanodes.parallelStream() | ||
| .forEach(dn -> { | ||
| dn.stop(); |
There was a problem hiding this comment.
shall we wrap them in try catch to cleanup all of them silently.
There was a problem hiding this comment.
Thanks for the review Ajay, I didnot understand this comment completely. Can you please elaborate. ?
|
I am also +1, but I really agree with @bharatviswa504 , we probably should not wait for a day for the MiniOzoneCluster to shutdown. +1 after fixing that issue. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…tion processing code This PR also refactors TestSamzaSqlRemoteTable to be in samza-test instead of samza-sql, since it seems to actually be an integration test. It is useful to move that test in this PR so that tests that may need an external context can be consolidated. Author: Cameron Lee <[email protected]> Reviewers: Prateek Maheshwari <[email protected]>, Shanthoosh Venkatraman <[email protected]> Closes apache#829 from cameronlee314/external_context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiniOzoneCluster is not shutting down all the threads during shutdown. this patch tries to fix that issue.