Skip to content

Conversation

ok2c
Copy link
Member

@ok2c ok2c commented Oct 4, 2025

No description provided.

@ok2c ok2c force-pushed the h2_priority_code_cleanup branch from e7165b8 to 2c6dcf3 Compare October 4, 2025 07:57
@ok2c
Copy link
Member Author

ok2c commented Oct 4, 2025

@arturobernalg Okay. here's the latest

  1. I removed unused protocol code
  2. I completely re-wrote PriorityFormatter for memory efficiency. Please take a look at my implementation and yours and compare them in terms of intermediate garbage generation. Message parsing / formatting usually used are in the hot execution path and MUST be efficient. That also implies memory efficiency.
  3. Changed the sample application. Classic over Async is still experimental and will likely be experimental for a long time. we should not promote it unless InputStream / OutputStream compatibility is really a necessity.

Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ok2c I never attached to H2Processors because was a experimental feature.

@ok2c ok2c merged commit e18248f into apache:master Oct 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants