Skip to content

Support snapshot_properties argument for add_files function #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
enkidulan opened this issue May 2, 2024 · 2 comments
Closed

Support snapshot_properties argument for add_files function #694

enkidulan opened this issue May 2, 2024 · 2 comments

Comments

@enkidulan
Copy link
Contributor

Feature Request / Improvement

It would be great to make the interface more aligned with append and overwrite function, which support snapshot_properties argument. The logic also seems simple enough to support the feature.
@Fokko
Copy link
Contributor

Fokko commented May 2, 2024

@enkidulan Thanks for raising this, and I agree! Are you interested in contributing to this feature?

@enkidulan enkidulan mentioned this issue May 2, 2024
Merged
@enkidulan
Copy link
Contributor Author

I've created a draft PR - #695

@sungwy sungwy closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enkidulan @Fokko @sungwy