Skip to content

Support reading initial-defaults #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 11, 2025

No description provided.

@gabeiglio
Copy link
Contributor

gabeiglio commented Feb 12, 2025

Since initial-default projection happens after filtering in _task_to_record_batches Im wondering if this will yield the correct results given a pyarrow_filter for this field.

@Fokko
Copy link
Contributor Author

Fokko commented Feb 14, 2025

Since initial-default projection happens after filtering in _task_to_record_batches Im wondering if this will yield the correct results given a pyarrow_filter for this field.

Thanks for pointing this out, and it doesn't handle the filtering correctly. Let me work on a fix. Thanks!

@gabeiglio
Copy link
Contributor

gabeiglio commented Feb 14, 2025

No problem! I was trying to get a test case for this by evolving the schema of a table and adding a new field with some initial-default value, but i think that have to wait for V3 table spec

@kevinjqliu
Copy link
Contributor

@Fokko could you rebase this when you get a chance

@Fokko
Copy link
Contributor Author

Fokko commented Apr 23, 2025

@kevinjqliu Sure, but I think this relies on #1770 to do some proper testing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants