Skip to content

fix adlss properties processing #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

ms32035
Copy link
Contributor

@ms32035 ms32035 commented Feb 27, 2025

We observed that the property with token returned by Polaris is adls.sas-token.<account name> and the extra condition causes is to be ignored

@Fokko
Copy link
Contributor

Fokko commented Feb 27, 2025

@ms32035 Thank you for raising this. Can you also run make lint?

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to add a unit test for this code?

@ms32035
Copy link
Contributor Author

ms32035 commented Feb 27, 2025

That probably would be a question to @Fokko who authored #1520

I'm not even sure what the correct property specification is (if any), and what other rest catalogs may return

@Fokko
Copy link
Contributor

Fokko commented Feb 27, 2025

This is the equivalent code on the Java side of things: https://github.com/apache/iceberg/blob/a50ec923f3d928f67e2a4a361c0d1162341aa084/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java#L49C39-L49C59

We could pull out the credential parsing and test that in isolation, or mock the AzureBlobFileSystem and make sure that it is initialized with the correct arguments.

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matches the java implementation
it would be nice to mock AzureBlobFileSystem and test, but not a blocker

@Fokko Fokko merged commit 9945f83 into apache:main Mar 4, 2025
7 checks passed
@Fokko Fokko added this to the PyIceberg 0.9.1 milestone Apr 20, 2025
Fokko pushed a commit that referenced this pull request Apr 25, 2025
We observed that the property with token returned by Polaris is
`adls.sas-token.<account name>` and the extra condition causes is to be
ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants