CI: Use Java 1.9.0-SNAPSHOT for testing #1899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With apache/iceberg#12593 Row lineage is required and Spark uses Java 1.8.0 that does not write the required `start-row-id` field in the snapshot. Therefore, I think it would be good to just use the SNAPSHOT for now until it gets released.
nastra
approved these changes
Apr 8, 2025
|
Thanks @nastra |
kevinjqliu
reviewed
Apr 13, 2025
| -Lo /opt/spark/jars/iceberg-spark-runtime-${ICEBERG_SPARK_RUNTIME_VERSION}-${ICEBERG_VERSION}.jar | ||
|
|
||
|
|
||
| # Download AWS bundle | ||
| RUN curl --retry 5 -s https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-aws-bundle/${ICEBERG_VERSION}/iceberg-aws-bundle-${ICEBERG_VERSION}.jar \ | ||
| RUN curl --retry 5 -s https://repository.apache.org/content/groups/snapshots/org/apache/iceberg/iceberg-aws-bundle/1.9.0-SNAPSHOT/iceberg-aws-bundle-1.9.0-20250408.002722-86.jar \ |
There was a problem hiding this comment.
ah this doesnt exist anymore, https://repository.apache.org/content/groups/snapshots/org/apache/iceberg/iceberg-aws-bundle/1.9.0-SNAPSHOT/
which causes CI to fail with
IllegalArgumentException: Cannot initialize FileIO implementation org.apache.iceberg.aws.s3.S3FileIO: Cannot find constructor for interface org.apache.iceberg.io.FileIO
Missing org.apache.iceberg.aws.s3.S3FileIO [java.lang.NoClassDefFoundError: software/amazon/awssdk/services/s3/model/S3Exception]
make: *** [Makefile:61: test-integration] Error 1
Error: Process completed with exit code 2.
cc @Fokko
There was a problem hiding this comment.
interestingly, iceberg-spark-runtime contains both 20250408 and 20250409 but iceberg-aws-bundle only has 20250409
There was a problem hiding this comment.
interestingly, iceberg-spark-runtime contains both 20250408 and 20250409 but iceberg-aws-bundle only has 20250409
Not sure what's going on there 🤔
The JARs are cleaned up weekly. Since the 0.9.0 SNAPSHOT is being voted on, I suggest bumping it to an available version. I've created a PR here: #1907
Fokko
added a commit
to Fokko/iceberg-python
that referenced
this pull request
Apr 28, 2025
This reverts commit aeb4493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With apache/iceberg#12593 Row lineage is required and Spark uses Java 1.8.0 that does not write the required
first-row-idfield in the snapshot.Therefore, I think it would be good to just use the SNAPSHOT for now until it gets released. We can easily revert the PR once that's done.
Closes #1898
Rationale for this change
Are these changes tested?
Are there any user-facing changes?