fix: add metadata_properties to _construct_parameters when update hive table #2013
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadai0308
force-pushed
the
fix/hive-client-does-not-update-table-properties
branch
from
fa27421 to
df294d1
Compare
Fokko
reviewed
May 19, 2025
There was a problem hiding this comment.
@kadai0308 thanks for working on this. Would it be possible to add a test? We have Hive container running that we use for tests. This way we don't break it in the future.
Maybe we can add a test somewhere here:
The
session_catalog_hive is a HiveCatalog.
| @@ -541,6 +548,7 @@ def commit_table( | |||
| hive_table.parameters = _construct_parameters( | |||
| metadata_location=updated_staged_table.metadata_location, | |||
| previous_metadata_location=current_table.metadata_location, | |||
| metadata_properties=updated_staged_table.properties, | |||
There was a problem hiding this comment.
We also invoke this at line 363, should we also pass in the properties there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2010
Rationale for this change
This change adds metadata_properties to the _construct_parameters function to ensure metadata properties are included in the parameters.
I'm not entirely confident about the changes, so please let me know if my understanding is correct—if so, I’ll proceed to add tests.
Thanks you!
Are these changes tested?
Not yet.
Are there any user-facing changes?
Not sure.