Skip to content

Add support for categorical type #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2024
Merged

Add support for categorical type #693

merged 3 commits into from
May 7, 2024

Conversation

sungwy
Copy link
Collaborator

@sungwy sungwy commented May 2, 2024

Fixes: #450

DictionaryType is a separate type in Arrow, but isn't in Parquet.

Similar to how Arrow handles Dictionary Types, we will simply infer the Iceberg Type from the value_type of the provided DictionaryType field.

@sungwy sungwy requested a review from Fokko May 2, 2024 15:24
HonahX
HonahX reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Thanks @syun64. Just have one general question: Shall we throw a warning that we will not convert the field back to dictionary type when reading?

HonahX
HonahX approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the warning!

Fokko
Fokko approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syun64 Looking good 👍

@Fokko Fokko merged commit 0508667 into apache:main May 7, 2024
7 checks passed
@sungwy sungwy deleted the categoricals branch May 7, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@HonahX HonahX HonahX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Categoricals as a data type in the writer
3 participants
@sungwy @Fokko @HonahX