Skip to content

Remove trailing slash from table location when creating a table #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2024
Merged

Remove trailing slash from table location when creating a table #702

merged 6 commits into from
May 6, 2024

Conversation

felixscherz
Copy link
Contributor

Hi,
this is intended to resolve #606.
Changes:

  • use rstrip("/") when a location is specified for create_table
  • added tests for DynamoDbCatalog, GlueCatalog, HiveCatalog, RestCatalog and SqlCatalog

sungwy
sungwy approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@sungwy sungwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you for working on this fix!

HonahX
HonahX approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @felixscherz

@HonahX HonahX merged commit d872245 into apache:main May 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungwy sungwy sungwy approved these changes

@HonahX HonahX HonahX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove extraneous trailing slash in table location
3 participants
@felixscherz @sungwy @HonahX