feat(iceberg): introduce remove schemas #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanc-n
reviewed
Mar 19, 2025
jonathanc-n
reviewed
Mar 19, 2025
| @@ -482,6 +482,12 @@ pub enum TableUpdate { | |||
| /// Snapshot id to remove partition statistics for. | |||
| snapshot_id: i64, | |||
| }, | |||
| /// Remove schemas | |||
| #[serde(rename_all = "kebab-case")] | |||
| RemoveSchemas { | |||
ZENOTME
approved these changes
Mar 20, 2025
ZENOTME
reviewed
Mar 20, 2025
|
PTAL @Xuanwo @liurenjie1024 , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR introduces the capability to remove schemas to enable expire snapshot action operations.
https://github.com/apache/iceberg/blob/456bbe98b0b0982278a61af4c44d32e1c27417e2/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1177
https://github.com/apache/iceberg/blob/456bbe98b0b0982278a61af4c44d32e1c27417e2/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java#L249
refer to risingwavelabs#20
Are these changes tested?