Remove deprecated code #1141
Merged
Remove deprecated code #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-remove-deprecated-code
branch
2 times, most recently
from
22b8650 to
507a8de
Compare
Fokko
force-pushed
the
fd-remove-deprecated-code
branch
from
507a8de to
d77b907
Compare
jonathanc-n
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks for the cleanup @Fokko. Do we have a certain timeline for when deprecated code should be cleaned up? ex. number of versions, etc.
liurenjie1024
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?