Add support for evolving a partition column #1334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-evolve-partition
branch
2 times, most recently
from
1b10b21 to
e71b0bb
Compare
Fokko
force-pushed
the
fd-evolve-partition
branch
from
e71b0bb to
9a9174e
Compare
Fokko
changed the title
kevinjqliu
previously approved these changes
May 17, 2025
There was a problem hiding this comment.
LGTM
should we also add the same for timestamp, timestamp_ns, and decimal?
just to complete all lines in this table https://iceberg.apache.org/spec/#schema-evolution
Comment on lines
117
to
118
| # Create a table, and do some evolution on a partition column | ||
| spark.sql("CREATE OR REPLACE TABLE rest.default.test_promote_column (foo int) USING iceberg PARTITIONED BY (foo)") |
There was a problem hiding this comment.
nit I think we should keep the original test and just create another table for evolution on a partition column
| @@ -403,12 +403,26 @@ impl Datum { | |||
| } | |||
| } | |||
| PrimitiveType::Int => PrimitiveLiteral::Int(i32::from_le_bytes(bytes.try_into()?)), | |||
| PrimitiveType::Long => PrimitiveLiteral::Long(i64::from_le_bytes(bytes.try_into()?)), | |||
| PrimitiveType::Long => { | |||
There was a problem hiding this comment.
Relevant section from the spec: https://iceberg.apache.org/spec/#schema-evolution
There was a problem hiding this comment.
I first did only the V2 transformations for now. I've added a test for the float and decimal case as well 👍 Decimal works with the current code since we don't have a fixed number of bytes in contrast to int/long.
kevinjqliu
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
To check what happens if a partition column is evolved.
What changes are included in this PR?
Are these changes tested?