feat(catalog): Implement catalog loader for in memory #1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
68
to
70
| if props.contains_key(MEMORY_CATALOG_IO_TYPE) { | ||
| self.0.io_type = props.get(MEMORY_CATALOG_IO_TYPE).cloned() | ||
| } |
There was a problem hiding this comment.
I don't think we need this, we could infer from MEMORY_CATALOG_WAREHOUSE.
There was a problem hiding this comment.
In that case we also need to make warehouse non-optional. Or do you mean when warehouse is set, infer the file io from warehouse scheme but can still keep the io type when warehouse is not set?
There was a problem hiding this comment.
Thanks @lliangyu-lin for this pr, generally LGTM! Just two nits.
| ) -> impl Future<Output = Result<Self::C>> + Send { | ||
| self.0.name = Some(name.into()); | ||
|
|
||
| // if props.contains_key(MEMORY_CATALOG_IO_TYPE) { |
There was a problem hiding this comment.
Missed it. Will remove this
| file_io, | ||
| warehouse_location, | ||
| file_io: FileIO::from_path(&config.warehouse) | ||
| .unwrap() |
There was a problem hiding this comment.
I don't think we should unwrap here.
liurenjie1024
approved these changes
Aug 28, 2025
Fokko
pushed a commit
that referenced
this pull request
Sep 1, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> * Previous #1600 added few integration tests, but need to include the new changes introduced in memory catalog loader change #1623 . * This caused build failures ## Are these changes tested? Yes, existing tests <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
Yes, updated existing tests