[infra] nightly pypi build for pyiceberg_core
#948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
commented
Feb 7, 2025
kevinjqliu
force-pushed
the
kevinjqliu/nightly-pyiceberg-core
branch
2 times, most recently
from
9c4dd8d to
5c24fc0
Compare
kevinjqliu
commented
Feb 18, 2025
Xuanwo
reviewed
Feb 18, 2025
kevinjqliu
force-pushed
the
kevinjqliu/nightly-pyiceberg-core
branch
from
72fef36 to
c854549
Compare
|
Rebased and addressed @Xuanwo 's concern with building wheels. I'll set up trusted publishing for |
Xuanwo
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Looks great to me. Let see how @Fokko and @liurenjie1024 think about this.
liurenjie1024
approved these changes
Feb 19, 2025
|
Let's wait for a moment for @Fokko to take a look at this as he's more familiar with python. |
|
Added trusted published to testpypi's
|
Fokko
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
This looks great, thanks @kevinjqliu for working on this, and @liurenjie1024 and @Xuanwo for the review 🚀
kevinjqliu
added a commit
that referenced
this pull request
Feb 21, 2025
Follow up to #948 I found a bug in the nightly pypi build where the version timestamp changes within the jobs, causing a single run to push multiple versions. This PR fixes the issue by setting the version timestamp once for the entire workflow and then pass it down to individual jobs. This should ensure a consistency version Workflow run: https://github.com/apache/iceberg-rust/actions/runs/13460497360 Testpypi: https://test.pypi.org/project/pyiceberg-core-kevinliu/#history Tested on my fork: Worfklow run: https://github.com/kevinjqliu/iceberg-rust/actions/runs/13461643730 Testpypi on my fork: https://test.pypi.org/project/pyiceberg-core-kevinliu/0.4.0.dev20250221170617/#files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by pyiceberg#1601 & https://github.com/apache/iceberg-python/blob/main/.github/workflows/nightly-pypi-build.yml
This PR adds nightly build of
pyiceberg_coreto testpypi.I have successfully tested the github action on my fork by pushing to my own package,
I've also verified library versions locally