Test: Verify variant logical type annotation of Parquet writer #14306
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/parquet-variant-type-logical-annotation
branch
from
35cfcdd to
1fe88c4
Compare
ebyhr
force-pushed
the
ebi/parquet-variant-type-logical-annotation
branch
from
1fe88c4 to
2c74c3c
Compare
huaxingao
approved these changes
Oct 13, 2025
|
cc @aihuaxu |
singhpk234
approved these changes
Oct 13, 2025
Comment on lines
+258
to
+262
| if (column.type() == Types.VariantType.get()) { | ||
| int fieldIndex = schema.getFieldIndex(column.name()); | ||
| assertThat(schema.getFields().get(fieldIndex).getLogicalTypeAnnotation()) | ||
| .isEqualTo(LogicalTypeAnnotation.variantType(Variant.VARIANT_SPEC_VERSION)); | ||
| } |
There was a problem hiding this comment.
nit:
can we club this read with the read below ?
There was a problem hiding this comment.
Maybe no? The subsequent Parquet reader doesn't expose logical type annotations.
I assume we intentionally use Parquet.read instead of the low-level ParquetFileReader because it's the primary API intended for third-party developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #13941
Closes #13498