Spark: Deprecate unused methods in SparkTableUtil and SparkSchemaUtil #14308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
reviewed
Oct 13, 2025
| * @return the equivalent Schema | ||
| * @throws IllegalArgumentException if the type cannot be converted or there are missing ids | ||
| */ | ||
| public static Schema convertWithFreshIds(Schema baseSchema, StructType sparkType) { |
There was a problem hiding this comment.
These are public APIs. I think we need to deprecate first.
There was a problem hiding this comment.
Is the deprecation process required even in Spark module?
There was a problem hiding this comment.
+1 on deprecating this first, some folks do rely on this, from what i am aware
There was a problem hiding this comment.
Thanks, I didn't know the usage. Reverted removal and added @deprecated instead.
ebyhr
force-pushed
the
ebi/spark-unused-method
branch
from
a8620e4 to
dbdaf39
Compare
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/spark-unused-method
branch
from
dbdaf39 to
10433e3
Compare
ebyhr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.