Core: Explicitly close SeekableInput in the AvroIterable #14322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
approved these changes
Oct 14, 2025
|
LGTM. +1 to add a test if possible. |
nastra
approved these changes
Oct 15, 2025
ebyhr
force-pushed
the
ebi/serafin/close-avro-stream
branch
from
b282c4e to
f01016a
Compare
|
I added a unit test and confirmed that it fails without this fix. |
ebyhr
force-pushed
the
ebi/serafin/close-avro-stream
branch
from
f01016a to
9c049e8
Compare
nastra
reviewed
Oct 16, 2025
core/src/test/java/org/apache/iceberg/avro/TestAvroIterable.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Oct 16, 2025
| try (MockedStatic<AvroIO> avroIo = mockStatic(AvroIO.class)) { | ||
| avroIo.when(() -> AvroIO.stream(seekableInputStream, 100L)).thenReturn(seekableInput); | ||
|
|
||
| try (MockedStatic<DataFileReader> dataFileReaderMock = mockStatic(DataFileReader.class)) { |
There was a problem hiding this comment.
we could move this into the upper try block and safe us one level of nesting
When avro file is malformed, DataFileReader.openReader can exit by throwing InvalidAvroMagicException which will leave input stream open and in the result, leaked. Co-Authored-By: Eduard Tudenhoefner <[email protected]> Co-Authored-By: Mateusz "Serafin" Gajewski <[email protected]>
ebyhr
force-pushed
the
ebi/serafin/close-avro-stream
branch
from
146bf8c to
3c7ee09
Compare
nastra
approved these changes
Oct 16, 2025
singhpk234
approved these changes
Oct 16, 2025
|
Thanks for the fix @ebyhr @wendigo ! Thank you for the reviews @huaxingao and @nastra ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When avro file is malformed, DataFileReader.openReader can exit by throwing InvalidAvroMagicException which will leave input stream open and in the result, leaked.
Supersedes #13409