-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Shift site build to use monorepo and gh-pages #8919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fff5c34
to
b9a11ac
Compare
496a18b
to
656ad3b
Compare
005af4d
to
a374bd1
Compare
pip -q install -r requirements.txt --upgrade | ||
} | ||
|
||
assert_not_empty () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a huge deal but may help to pass through an error message so we know which arg is missing
Echo "Missing an argument: $2 "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw a few nits in the docs, but worked well locally for me. Worktree code seems to working as expected but i'm not an expert in their usage for something like this.
b0535ab
to
f870a4b
Compare
a0ce345
to
884a181
Compare
8b25f83
to
3dc0161
Compare
311b814
to
c0f630d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments. I did a local build and it all works. The UI needs a bit of rework, but we can do that in a separate PR. What I do think is that we need to add 1.4.3 in https://github.com/apache/iceberg/tree/docs before merging this.
@@ -1128,6 +1125,41 @@ Example | |||
] } ] | |||
``` | |||
|
|||
### Content File (Data and Delete) Serialization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but it would be good at some point to just include the spec from the repository itself.
deb0736
to
9cdc724
Compare
@Fokko I updated after your comments! |
…berg look and feel Co-authored-by: Muna Bedan <[email protected]>
9cdc724
to
2c589f6
Compare
This looks great, and I don't see any open comments. If there is anything we can follow up on in a separate PR. I'll go ahead and rebase and merge this 🚀 Thanks for the reviews @rdblue, @RussellSpitzer, and a special thanks to @bitsondatadev for taking care of the docs! |
Revert back to using the
site
directory which contains the monorepo of the site and versioned docs. Adds in the site styling to look like the current Apache Iceberg site. Adds the main build infrastructure.I gleaned info from this PR, this PR, this PR and a bit off of this deploy script.
Here is a link to the gh-pages in my branch: https://bitsondatadev.github.io/iceberg/
I will be doing another PR to handle the following task items. when we get some eyes on the current site and if anyone sees any issues.
Also move back to using the asf infra standards including the asf-site branch.
This PR will be moving
/docs/docs/nightly/
up to/docs/nightly/
based on some bad state that happened when we pulled the versioned docs into the worktree. So most of the changed files are just those files being moved.