Skip to content

Shift site build to use monorepo and gh-pages #8919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

bitsondatadev
Copy link
Collaborator

@bitsondatadev bitsondatadev commented Oct 25, 2023

Revert back to using the site directory which contains the monorepo of the site and versioned docs. Adds in the site styling to look like the current Apache Iceberg site. Adds the main build infrastructure.

I gleaned info from this PR, this PR, this PR and a bit off of this deploy script.

Here is a link to the gh-pages in my branch: https://bitsondatadev.github.io/iceberg/

I will be doing another PR to handle the following task items. when we get some eyes on the current site and if anyone sees any issues.

Also move back to using the asf infra standards including the asf-site branch.

This PR will be moving /docs/docs/nightly/ up to /docs/nightly/ based on some bad state that happened when we pulled the versioned docs into the worktree. So most of the changed files are just those files being moved.

@bitsondatadev bitsondatadev force-pushed the asf-deploy branch 6 times, most recently from fff5c34 to b9a11ac Compare October 25, 2023 12:05
@bitsondatadev bitsondatadev force-pushed the asf-deploy branch 7 times, most recently from 496a18b to 656ad3b Compare November 6, 2023 12:37
@bitsondatadev bitsondatadev force-pushed the asf-deploy branch 3 times, most recently from 005af4d to a374bd1 Compare November 8, 2023 06:52
pip -q install -r requirements.txt --upgrade
}

assert_not_empty () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a huge deal but may help to pass through an error message so we know which arg is missing

Echo "Missing an argument: $2 "

Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw a few nits in the docs, but worked well locally for me. Worktree code seems to working as expected but i'm not an expert in their usage for something like this.

@bitsondatadev bitsondatadev force-pushed the asf-deploy branch 5 times, most recently from a0ce345 to 884a181 Compare December 21, 2023 06:32
@bitsondatadev bitsondatadev force-pushed the asf-deploy branch 5 times, most recently from 8b25f83 to 3dc0161 Compare December 29, 2023 14:59
@bitsondatadev bitsondatadev force-pushed the asf-deploy branch 5 times, most recently from 311b814 to c0f630d Compare January 5, 2024 20:04
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments. I did a local build and it all works. The UI needs a bit of rework, but we can do that in a separate PR. What I do think is that we need to add 1.4.3 in https://github.com/apache/iceberg/tree/docs before merging this.

@@ -1128,6 +1125,41 @@ Example
] } ]
```

### Content File (Data and Delete) Serialization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but it would be good at some point to just include the spec from the repository itself.

@bitsondatadev bitsondatadev force-pushed the asf-deploy branch 2 times, most recently from deb0736 to 9cdc724 Compare January 5, 2024 21:03
@bitsondatadev
Copy link
Collaborator Author

@Fokko I updated after your comments!

@Fokko
Copy link
Contributor

Fokko commented Jan 9, 2024

This looks great, and I don't see any open comments. If there is anything we can follow up on in a separate PR. I'll go ahead and rebase and merge this 🚀 Thanks for the reviews @rdblue, @RussellSpitzer, and a special thanks to @bitsondatadev for taking care of the docs!

@Fokko Fokko merged commit 9bd5dec into apache:main Jan 9, 2024
@ajantha-bhat ajantha-bhat mentioned this pull request Jan 24, 2024
@bitsondatadev bitsondatadev mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants