Skip to content

MINOR: remove storage/src/generated from tracked files #10637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021

Conversation

chia7712
Copy link
Member

@chia7712 chia7712 commented May 6, 2021

related to #10271

The generated code from other modules have beed excluded from tracked files.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712 chia7712 requested a review from junrao May 6, 2021 06:17
@chia7712
Copy link
Member Author

chia7712 commented May 6, 2021

@satishd @kowshik FYI

Copy link
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 : Thanks for the PR. LGTM

@kowshik
Copy link
Contributor

kowshik commented May 7, 2021

@chia7712 Thanks for the PR. LGTM.

Copy link
Member

@satishd satishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chia7712 for the PR, LGTM.

@chia7712 chia7712 merged commit f109240 into apache:trunk May 7, 2021
@ableegoldman
Copy link
Member

Is it possible to set up the gitignore to automatically ignore anything under a generated/ subdirectory?

@chia7712
Copy link
Member Author

Is it possible to set up the gitignore to automatically ignore anything under a generated/ subdirectory?

please take a look at #10671

@chia7712 chia7712 deleted the MINOR-10637 branch March 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants