MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters' #9421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please. |
|
@dongjinleekr Thanks for your effort. nit: It would be better to avoid changing unrelated code in order to make this patch small but tough :) |
|
@chia7712 Great. I will separate the other commits into independent PR to make the commit clear. Stay tuned! 😄 |
…lectionConverters'
dongjinleekr
force-pushed
the
cleanup/202010
branch
from
bc21a5b to
1494220
Compare
|
I don't think this PR will work with Scala 2.12. See scala/scala-collection-compat#346 |
|
Closing for it won't work with Scala 2.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with fixing typo, removing redundant method parameters, unused Throwables, and unused test methods.
Committer Checklist (excluded from commit message)