-
Notifications
You must be signed in to change notification settings - Fork 941
[KYUUBI #6884] [FEATURE] Support to reassign the batches to alternative kyuubi instance in case kyuubi instance lost #7037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7037 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 695 699 +4
Lines 42833 43138 +305
Branches 5833 5859 +26
=======================================
- Misses 42833 43138 +305 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new feature to reassign batches to an alternative Kyuubi instance in case the original instance is lost. The changes include the addition of a new DTO class to encapsulate the response of the reassign operation.
- Introduces ReassignBatchResponse DTO with fields for success and message
- Implements standard methods like equals, hashCode, and toString for the new DTO
Files not reviewed (3)
- kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala: Language not supported
- kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala: Language not supported
- kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/BatchesResourceSuite.scala: Language not supported
Comments suppressed due to low confidence (1)
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/ReassignBatchResponse.java:26
- [nitpick] Consider renaming 'msg' to 'message' in the DTO for improved clarity and consistency with common naming conventions.
private String msg = null;
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala
Outdated
Show resolved
Hide resolved
…nstance in case kyuubi instance lost
rebased the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cc @pan3793
quite useful and nice feature for failure tolerance, I will take a closer look next week |
bb66a58
to
f004520
Compare
31ab721
to
5f87ab2
Compare
Why are the changes needed?
Support to reassign the batches to alternative kyuubi instance in case kyuubi instance lost.
#6884
How was this patch tested?
Unit Test
Was this patch authored or co-authored using generative AI tooling?
No