Add type annotations for the base DNS API #1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parent class signature for methods which are overriden in the subclass. This means we sadly need to rely on annotations from the base class. See python/mypy#3903 for details.
Kami
commented
Mar 1, 2020
| @@ -21,14 +21,8 @@ | |||
|
|
|||
| from typing import Type, cast | |||
|
|
|||
| ec2_cls = get_driver(Provider.EC2) | |||
There was a problem hiding this comment.
Sadly this doesn't work as expected.
This means we need to rely on base / parent class annotations until we have type annotations for all the driver subclasses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds type annotations for the base DNS API.