This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Add new option "failOnWarning". #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option causes the maven-compiler-plugin to treat warnings as errors and fail accordingly. Simply adds "-Werror" to the compiler command line. It may be nice to add this to the plexus-compiler-api proper but as the sonatype repo only has tags to 2.4 and the current plugin references 2.6 (and I have no idea where that comes from), I went the easy route. Happy to refactor it if wanted.
|
Is this PR still relevant. If so, is there any reason not to pass to |
|
Hm. No comment for almost a year and then one comment and closed within 8 days. Yes, it is still relevant. As an option, I can expose this as a property with ...
<failOnWarning>${failWarningSwitch}</failOnWarning>
...so this can be overridden from the command line. If it gets added to , there is no way to control this dynamically from the command line. |
|
plexus compiler api 2.8.1 supports failOnWarning directly. I may simply redo this patch to leverage this. |
|
Let's reopen, Can you reopen, can you provide a PR? Provide a JIRA issue also, I will merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option causes the maven-compiler-plugin to treat warnings as errors
and fail accordingly.
Simply adds "-Werror" to the compiler command line. It may be nice to
add this to the plexus-compiler-api proper but as the sonatype repo only
has tags to 2.4 and the current plugin references 2.6 (and I have no
idea where that comes from), I went the easy route. Happy to refactor
it if wanted.