NIFI-10575 add minimum GitHub token permissions for workflows #6469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Kurmi <[email protected]>
ashishkurmi
changed the title
exceptionfactory
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Thanks for improvement and creating the associated Jira for tracking @boahc077! The changes look good! +1 merging
p-kimberley
pushed a commit
to p-kimberley/nifi
that referenced
this pull request
Oct 15, 2022
This closes apache#6469 Signed-off-by: David Handermann <[email protected]> Co-authored-by: Ashish Kurmi <[email protected]> Co-authored-by: Alex <[email protected]>
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds minimum token permissions for the GITHUB_TOKEN in GitHub Actions workflows using secure-workflows.
The GitHub Actions workflow has a GITHUB_TOKEN with write access to multiple scopes. Here is an example of the permissions in one of the workflow runs:
https://github.com/apache/nifi/actions/runs/3167551611/jobs/5158128990#step:1:19
After this change, the scopes will be reduced to the minimum needed for the following workflows:
Motivation and Context
Signed-off-by: Ashish Kurmi [email protected]