-
Notifications
You must be signed in to change notification settings - Fork 609
mbedtls-alt:Support for new algorithms in mbedtls alternative implementation #2621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbedtls-alt:Support for new algorithms in mbedtls alternative implementation #2621
Conversation
Signed-off-by: makejian <[email protected]>
…tions (1)aes-xts sets the key length to only 256 and 512 bits (2)when the key length of aes-xts is 512 bits, MAX_KEY_SIZE needs to be expanded to 64 bytes. (3)check invalid input length and mode Signed-off-by: makejian <[email protected]>
Signed-off-by: makejian <[email protected]>
Signed-off-by: makejian <[email protected]>
[Experimental Bot, please feedback here] Summary: The PR summary is generally okay but could be more detailed. For example:
Impact:
Testing:
Overall: The PR does not fully meet the NuttX requirements yet. It needs more specific information in the Summary and Impact sections and more detailed evidence of testing. |
1f03c51
to
83d0984
Compare
Thank you @ThePassionate :-) Can you please provide output logs of testing after change with instructions on how to reproduce? :-) |
Signed-off-by: makejian <[email protected]>
83d0984
to
3cf1383
Compare
Thanks, patch has beed updated. please review again. :-) |
Summary
Impact
N/A
Testing
ci & mbedselftest
nsh> mbedselftest ripemd160 poly1305 mpi
RIPEMD-160 test #1: passed
RIPEMD-160 test #2: passed
RIPEMD-160 test #3: passed
RIPEMD-160 test #4: passed
RIPEMD-160 test #5: passed
RIPEMD-160 test #6: passed
RIPEMD-160 test #7: passed
RIPEMD-160 test #8: passed
Poly1305 test 0 passed
Poly1305 test 1 passed
MPI test #1 (mul_mpi): passed
MPI test #2 (div_mpi): passed
MPI test #3 (exp_mod): passed
MPI test #4 (inv_mod): passed
MPI test #5 (simple gcd): passed
Executed 3 test suites
[ All tests PASS ]
can repeat with
CONFIG_MBEDTLS_POLY1305_ALT
CONFIG_MBEDTLS_RIPEMD160_ALT
CONFIG_MBEDTLS_BIGNUM_ALT
CONFIG_MBEDTLS_APP_SELFTEST
and execute
mbedselftest ripemd160 poly1305 mpi