Gradle / Kotlin + move common parts to project-plugin #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
changed the title
snazy
force-pushed
the
gradle-kts
branch
2 times, most recently
from
1fd5db7 to
2cddd3f
Compare
snazy
changed the title
snazy
changed the title
adutra
reviewed
Aug 6, 2024
adutra
previously approved these changes
Aug 6, 2024
Migrate Gradle/Groovy to Gradle/Kotlin-script. Gradle/Kotlin is a bit slower to compile, but has proper type-safety and really good support in at least IntelliJ, and actually makes debugging build scripts possible. Gradle/Groovy is not really type safe and often yields quite surprising behavior. Also moves the common project configuration to the project plugin `polaris-server` and the "boring" parts of `/build.gradle.kts` to the project plugin `polaris-root`.
adutra
approved these changes
Aug 7, 2024
collado-mike
reviewed
Aug 7, 2024
Comment on lines
-26
to
-28
| implementation(project(":polaris-core")) | ||
| implementation(project(":polaris-eclipselink")) | ||
|
|
There was a problem hiding this comment.
@snazy , was it intentional that the polaris-eclipselink dependency wasn't included in the kotlin build? Or was that an oversight? I didn't see a mention of this in the PR description.
For changes to the build, I think a good practice would be to compare the contents of the bundled jars before and after to understand if there's a change in the build output
There was a problem hiding this comment.
Yea, my bad. That wasn't intentional.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Gradle/Groovy to Gradle/Kotlin-script.
Gradle/Kotlin is a bit slower to compile, but has proper type-safety and really good support in at least IntelliJ, and actually makes debugging build scripts possible. Gradle/Groovy is not really type safe and often yields quite surprising behavior.
Also moves the common project configuration to the project plugin
polaris-serverand the "boring" parts of/build.gradle.ktsto the project pluginpolaris-root.