[ISSUE #5205]Enable checkstyle for test code (rocketmq-logging) (#5258)

Author: byj520-lang

logging/pom.xml

@@ -15,7 +15,8 @@
   limitations under the License.
   -->
 
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <parent>
         <groupId>org.apache.rocketmq</groupId>
         <artifactId>rocketmq-all</artifactId>
@@ -44,4 +45,29 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <plugins>
+            <plugin>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>${maven-checkstyle-plugin.version}</version>
+                <executions>
+                    <execution>
+                        <id>validate</id>
+                        <phase>validate</phase>
+                        <configuration>
+                            <configLocation>${project.parent.basedir}/style/rmq_checkstyle.xml</configLocation>
+                            <inputEncoding>UTF-8</inputEncoding>
+                            <consoleOutput>true</consoleOutput>
+                            <failsOnError>true</failsOnError>
+                            <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                        </configuration>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
+
 </project>

logging/src/test/java/org/apache/rocketmq/logging/InnerLoggerFactoryTest.java

@@ -82,7 +82,6 @@ public void testInnerLoggerFactory() {
         logger3.debug("debug {}", "hahahah");
 
         String content = new String(byteArrayOutputStream.toByteArray());
-        System.out.println(content);
 
         Assert.assertTrue(content.contains("InnerLoggerFactoryTest"));
         Assert.assertTrue(content.contains("info"));

logging/src/test/java/org/apache/rocketmq/logging/inner/AppenderTest.java

@@ -91,8 +91,6 @@ public void testInnerFile() throws IOException {
 
         String content = readFile(file);
 
-        System.out.println(content);
-
         Assert.assertTrue(content.contains("info"));
         Assert.assertTrue(content.contains("RuntimeException"));
         Assert.assertTrue(!content.contains("debug"));

logging/src/test/java/org/apache/rocketmq/logging/inner/LayoutTest.java

@@ -48,7 +48,5 @@ public void testLogFormat() {
         LoggingEvent loggingEvent = new LoggingEvent(Logger.class.getName(), logger, org.apache.rocketmq.logging.inner.Level.INFO,
             "junit test error", null);
         String format = innerLayout.format(loggingEvent);
-
-        System.out.println(format);
     }
 }

logging/src/test/java/org/apache/rocketmq/logging/inner/LevelTest.java

@@ -30,8 +30,8 @@ public void levelTest() {
     }
 
     @Test
-    public void loggerLevel(){
+    public void loggerLevel() {
         Level level = Logger.getRootLogger().getLevel();
-        Assert.assertTrue(level!=null);
+        Assert.assertTrue(level != null);
     }
 }

logging/src/test/java/org/apache/rocketmq/logging/inner/LoggerTest.java

@@ -66,8 +66,6 @@ public void testInnerConsoleLogger() throws IOException {
 
         String result = new String(byteArrayOutputStream.toByteArray());
 
-        System.out.println(result);
-
         Assert.assertTrue(result.contains("info"));
         Assert.assertTrue(result.contains("RuntimeException"));
         Assert.assertTrue(result.contains("WATERMARK"));
@@ -101,8 +99,6 @@ public void testInnerFileLogger() throws IOException {
 
         String content = readFile(file);
 
-        System.out.println(content);
-
         Assert.assertTrue(content.contains("info"));
         Assert.assertTrue(content.contains("RuntimeException"));
         Assert.assertTrue(!content.contains("debug"));

logging/src/test/java/org/apache/rocketmq/logging/inner/MessageFormatterTest.java

@@ -25,15 +25,14 @@
 public class MessageFormatterTest {
 
     @Test
-    public void formatTest(){
+    public void formatTest() {
         InnerLoggerFactory.FormattingTuple logging = InnerLoggerFactory.MessageFormatter.format("this is {},and {}", "logging", 6546);
         String message = logging.getMessage();
         Assert.assertTrue(message.contains("logging"));
 
         InnerLoggerFactory.FormattingTuple format = InnerLoggerFactory.MessageFormatter.format("cause exception {}", 143545, new RuntimeException());
         String message1 = format.getMessage();
         Throwable throwable = format.getThrowable();
-        System.out.println(message1);
         Assert.assertTrue(throwable != null);
     }