Skip to content

Conversation

byj520-lang
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #5205

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.22%. Comparing base (294e263) to head (1e3a17e).
Report is 1329 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5258      +/-   ##
=============================================
- Coverage      43.28%   43.22%   -0.06%     
+ Complexity      7822     7817       -5     
=============================================
  Files            998      998              
  Lines          69454    69454              
  Branches        9171     9171              
=============================================
- Hits           30063    30024      -39     
- Misses         35624    35667      +43     
+ Partials        3767     3763       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaron-ai aaron-ai merged commit 32c7d37 into apache:develop Oct 10, 2022
@byj520-lang byj520-lang deleted the rocketmq-5205 branch October 10, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable checkstyle for test code (rocketmq-logging)
7 participants