Skip to content

Commit 7519a53

Browse files
authored
[ISSUE 3333] Remove commons-codes dependency (#3334)
1 parent fea769d commit 7519a53

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

client/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,6 @@
4747
<groupId>org.apache.commons</groupId>
4848
<artifactId>commons-lang3</artifactId>
4949
</dependency>
50-
<dependency>
51-
<groupId>commons-codec</groupId>
52-
<artifactId>commons-codec</artifactId>
53-
</dependency>
5450
<dependency>
5551
<groupId>io.opentracing</groupId>
5652
<artifactId>opentracing-api</artifactId>

client/src/main/java/org/apache/rocketmq/client/trace/TraceView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717

1818
package org.apache.rocketmq.client.trace;
1919

20+
import java.nio.charset.StandardCharsets;
2021
import java.util.ArrayList;
2122
import java.util.List;
22-
import org.apache.commons.codec.Charsets;
2323
import org.apache.rocketmq.common.message.MessageExt;
2424

2525
public class TraceView {
@@ -40,7 +40,7 @@ public class TraceView {
4040

4141
public static List<TraceView> decodeFromTraceTransData(String key, MessageExt messageExt) {
4242
List<TraceView> messageTraceViewList = new ArrayList<TraceView>();
43-
String messageBody = new String(messageExt.getBody(), Charsets.UTF_8);
43+
String messageBody = new String(messageExt.getBody(), StandardCharsets.UTF_8);
4444
if (messageBody == null || messageBody.length() <= 0) {
4545
return messageTraceViewList;
4646
}

client/src/test/java/org/apache/rocketmq/client/trace/TraceViewTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717

1818
package org.apache.rocketmq.client.trace;
1919

20-
import org.apache.commons.codec.Charsets;
2120
import org.apache.rocketmq.common.message.MessageExt;
2221
import org.apache.rocketmq.common.message.MessageType;
2322
import org.junit.Assert;
2423
import org.junit.Test;
2524

25+
import java.nio.charset.StandardCharsets;
2626
import java.util.List;
2727

2828
public class TraceViewTest {
@@ -46,7 +46,7 @@ public void testDecodeFromTraceTransData() {
4646
.append(true).append(TraceConstants.FIELD_SPLITOR)
4747
.toString();
4848
MessageExt message = new MessageExt();
49-
message.setBody(messageBody.getBytes(Charsets.UTF_8));
49+
message.setBody(messageBody.getBytes(StandardCharsets.UTF_8));
5050
String key = "AC1415116D1418B4AAC217FE1B4E0000";
5151
List<TraceView> traceViews = TraceView.decodeFromTraceTransData(key, message);
5252
Assert.assertEquals(traceViews.size(), 1);

0 commit comments

Comments
 (0)