Skip to content

Conversation

areyouok
Copy link
Contributor

@areyouok areyouok commented Sep 9, 2021

#3333

There is only one class (org.apache.commons.codec.Charsets) of commons-codec is used in rocketmq, which can be replaced with java.nio.charset.StandardCharsets (java 7).

So the commons-codec can be removed.

@areyouok areyouok changed the title [ISSUE 3333] Remove commons-codes dependency [ISSUE #3333] Remove commons-codes dependency Sep 9, 2021
@areyouok areyouok added the progress/wip Work in progress. Accept or refused to be continue. label Sep 9, 2021
@areyouok areyouok added this to the 4.9.2 milestone Sep 9, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 54.18% when pulling 2ad7477 on areyouok:remove_commons_codec into fea769d on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3334 (2ad7477) into develop (857d28d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3334      +/-   ##
=============================================
+ Coverage      47.95%   48.01%   +0.05%     
- Complexity      4559     4562       +3     
=============================================
  Files            552      552              
  Lines          36538    36538              
  Branches        4822     4822              
=============================================
+ Hits           17523    17544      +21     
+ Misses         16798    16774      -24     
- Partials        2217     2220       +3     
Impacted Files Coverage Δ
...va/org/apache/rocketmq/client/trace/TraceView.java 73.13% <100.00%> (ø)
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 55.54% <0.00%> (-0.31%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.92% <0.00%> (+0.31%) ⬆️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 69.55% <0.00%> (+0.51%) ⬆️
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.94% <0.00%> (+0.66%) ⬆️
.../rocketmq/broker/filter/ConsumerFilterManager.java 73.09% <0.00%> (+0.89%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857d28d...2ad7477. Read the comment docs.

@areyouok areyouok merged commit 7519a53 into apache:develop Sep 10, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progress/wip Work in progress. Accept or refused to be continue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants