[ISSUE #1843] Fix broker error when producer send to retry topic #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
producer send message to retry topic directly, broker will panic because maxReconsumeTimes is null and convert to int. add null check for maxReconsumeTimes Closes apache#1843
xujianhai666
changed the title
ShannonDing
changed the title
ShannonDing
approved these changes
Apr 14, 2020
tianliuliu
pushed a commit
to tianliuliu/rocketmq
that referenced
this pull request
Dec 21, 2021
…ic (apache#1844) producer send message to retry topic directly, broker will panic because maxReconsumeTimes is null and convert to int. add null check for maxReconsumeTimes Closes apache#1843
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
…ic (apache#1844) producer send message to retry topic directly, broker will panic because maxReconsumeTimes is null and convert to int. add null check for maxReconsumeTimes Closes apache#1843
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
…ic (apache#1844) producer send message to retry topic directly, broker will panic because maxReconsumeTimes is null and convert to int. add null check for maxReconsumeTimes Closes apache#1843
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
…ic (apache#1844) producer send message to retry topic directly, broker will panic because maxReconsumeTimes is null and convert to int. add null check for maxReconsumeTimes Closes apache#1843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
producer send message to retry topic directly, broker will panic
because maxReconsumeTimes is null and convert to int.
changes
add null check for maxReconsumeTimes
Closes #1843