[ISSUE #2535] Use one variable value to log info when eventQueue's size more than 10000. #2536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e's size more than 10000.
Codecov Report
@@ Coverage Diff @@
## develop #2536 +/- ##
=============================================
- Coverage 45.97% 45.94% -0.03%
+ Complexity 4318 4316 -2
=============================================
Files 547 547
Lines 36236 36237 +1
Branches 4808 4808
=============================================
- Hits 16658 16648 -10
- Misses 17491 17503 +12
+ Partials 2087 2086 -1 Continue to review full report at Codecov.
|
lizhiboo
reviewed
Feb 24, 2021
| this.eventQueue.add(event); | ||
| } else { | ||
| log.warn("event queue size[{}] enough, so drop this event {}", this.eventQueue.size(), event.toString()); | ||
| log.warn("event queue size[{}] enough, so drop this event {}", currentSize, event.toString()); |
There was a problem hiding this comment.
IMO, print currentSize and maxSize will be better.
There was a problem hiding this comment.
please take a look the new msg.
yuz10
approved these changes
Dec 10, 2021
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
* [ISSUE apache#2535] Use one variable value to log info when eventQueue's size more than 10000. * add the queue limit value when evenQueue size is enough.
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
* [ISSUE apache#2535] Use one variable value to log info when eventQueue's size more than 10000. * add the queue limit value when evenQueue size is enough.
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
* [ISSUE apache#2535] Use one variable value to log info when eventQueue's size more than 10000. * add the queue limit value when evenQueue size is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix-#2535
Use one variable value to log info when eventQueue's size more than 10000.