Skip to content

Conversation

drgnchan
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #2849

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 52.1% when pulling e14f66e on drgnchan:develop into f77d7fe on apache:develop.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #2851 (e14f66e) into develop (f77d7fe) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2851      +/-   ##
=============================================
- Coverage      46.92%   46.48%   -0.44%     
- Complexity      3475     4397     +922     
=============================================
  Files            309      549     +240     
  Lines          29192    36399    +7207     
  Branches        4178     4819     +641     
=============================================
+ Hits           13697    16921    +3224     
- Misses         13635    17362    +3727     
- Partials        1860     2116     +256     
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/rocketmq/client/ClientConfig.java 59.39% <100.00%> (ø) 29.00 <0.00> (ø)
.../rocketmq/common/utils/NameServerAddressUtils.java 40.00% <100.00%> (ø) 4.00 <0.00> (?)
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (-1.29%) 8.00% <0.00%> (ø%)
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java 59.18% <0.00%> (-1.03%) 11.00% <0.00%> (-1.00%)
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.47% <0.00%> (-0.66%) 17.00% <0.00%> (ø%)
...a/org/apache/rocketmq/store/StoreStatsService.java 28.85% <0.00%> (-0.66%) 25.00% <0.00%> (-1.00%)
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.92% <0.00%> (-0.48%) 3.00% <0.00%> (ø%)
...main/java/org/apache/rocketmq/store/CommitLog.java 66.42% <0.00%> (-0.11%) 79.00% <0.00%> (ø%)
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 73.60% <0.00%> (ø) 17.00% <0.00%> (ø%)
...rg/apache/rocketmq/common/sysflag/PullSysFlag.java 33.33% <0.00%> (ø) 5.00% <0.00%> (?%)
... and 245 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77d7fe...e14f66e. Read the comment docs.

@duhenglucky duhenglucky merged commit fb0d019 into apache:develop May 6, 2021
@zongtanghu zongtanghu added this to the 4.9.0 milestone Jun 4, 2021
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
fix some nonconformity after checkstyle
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
fix some nonconformity after checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants